Bug 13662

Summary: REGRESSION (r21367): Crash due to null document deref when closing bookmarks
Product: WebKit Reporter: Kevin M. Dean <kevin>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, dev+webkit, jrgbrbs, mjs
Priority: P1 Keywords: InRadar, Regression
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Crash log none

Kevin M. Dean
Reported 2007-05-10 12:18:45 PDT
After the webkit start page loads, I click my bookmarks view to open which works fine. I click it again to close and webkit crashes.
Attachments
Crash log (29.22 KB, text/plain)
2007-05-10 12:19 PDT, Kevin M. Dean 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Kevin M. Dean
Comment 1 2007-05-10 12:19:10 PDT
Created attachment 14474 [details] Crash log
Matt Lilek
Comment 2 2007-05-10 12:37:46 PDT
Debug build of r21371 gives me the following assertion failure: ASSERTION FAILED: document (WebKit/WebCore/loader/FrameLoader.cpp:3758 saveDocumentState)
Matt Lilek
Comment 3 2007-05-10 12:43:34 PDT
CCing Maciej, this assert was just added in r21367.
Brady Eidson
Comment 4 2007-05-10 12:54:30 PDT
Note there is both an ASSERT and a crash in a release build due to null deref - updating the title Also, while the effect on Mac seems to be narrow (Bookmarks view only, perhaps?) it has a broader effect x-platform. From #webkit a few moments ago - "zecke: WebKit/Gdk started to crash after mjs's change. Somehow it is managed to call FrameLoader::saveDocumentState with m_frame->document == 0"
Mark Rowe (bdash)
Comment 5 2007-05-10 20:59:43 PDT
*** Bug 13671 has been marked as a duplicate of this bug. ***
Maciej Stachowiak
Comment 6 2007-05-11 13:36:19 PDT
<rdar://problem/5197622>
David Kilzer (:ddkilzer)
Comment 7 2007-05-12 23:09:54 PDT
Fixed in r21421.
Note You need to log in before you can comment on or make changes to this bug.