| Summary: | REGRESSION(r173441): [GTK] All buttons appear insensitive | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> | ||||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cgarcia, commit-queue, esprehn+autocc, glenn, gustavo, kondapallykalyan, pnormand, svillar | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| Attachments: |
|
||||||||
RenderTheme::isReadOnlyControl() changed in r173441 we should only used it to render text based forms insensitive. Created attachment 237957 [details]
Patch
Comment on attachment 237957 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237957&action=review > Source/WebCore/ChangeLog:9 > + render non text based forms sensitive or unsesitive, isEnabled() unsensitive Committed r173559: <http://trac.webkit.org/changeset/173559> |
Created attachment 237758 [details] screenshot showing insensitive combos Using GTK+ and WebKit master, all buttons, combo boxes, etc. appear insensitive at all times, though they work fine. This persists if I roll back to GTK+ 3.13.7, which definitely worked fine with 2.5.3 and up until quite recently, so this is a regression in WebKit. Suspicion: until quite recently, selected rows were not properly highlighted in combo boxes and lists. Maybe the fix for that is what caused this to break.