Bug 136606

Summary: Web Inspector: disambiguate integral and real number primitive types in the protocol
Product: WebKit Reporter: Brian Burg <burg>
Component: Web InspectorAssignee: Brian Burg <burg>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, mkwst, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch timothy: review+

Brian Burg
Reported 2014-09-06 17:32:18 PDT
Misc cleanup post-code generator rewrite.
Attachments
Patch (80.27 KB, patch)
2014-09-09 22:55 PDT, Brian Burg 		no flags
DetailsFormatted DiffDiff
Patch (79.37 KB, patch)
2014-09-10 15:22 PDT, Brian Burg 		no flags
DetailsFormatted DiffDiff
Patch (79.39 KB, patch)
2014-09-11 19:16 PDT, Brian Burg 		timothy: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-09-06 17:32:28 PDT
<rdar://problem/18258060>
Brian Burg
Comment 2 2014-09-09 22:55:20 PDT
Created attachment 237880 [details] Patch
Timothy Hatcher
Comment 3 2014-09-10 08:11:44 PDT
Comment on attachment 237880 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237880&action=review Looks good, but I think the new names aren't great. > Source/JavaScriptCore/inspector/InspectorValues.h:62 > + Real, > + Integral, I think Double and Integer would be better here and throughout this patch. Even if that would be less accurate, it does tend to be the names we use in WebKit and JavaScript.
Brian Burg
Comment 4 2014-09-10 15:22:30 PDT
Created attachment 237908 [details] Patch
Timothy Hatcher
Comment 5 2014-09-11 00:12:12 PDT
Comment on attachment 237908 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237908&action=review > Source/JavaScriptCore/inspector/InspectorValues.h:278 > + void pushIntegral(int); > + void pushReal(double); Missed these (and callers)?
Brian Burg
Comment 6 2014-09-11 11:32:42 PDT
Comment on attachment 237908 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237908&action=review >> Source/JavaScriptCore/inspector/InspectorValues.h:278 >> + void pushReal(double); > > Missed these (and callers)? Oops, grep fail.
Brian Burg
Comment 7 2014-09-11 19:16:31 PDT
Created attachment 238007 [details] Patch
Brian Burg
Comment 8 2014-09-11 21:53:42 PDT
Committed r173554: <http://trac.webkit.org/changeset/173554>
Note You need to log in before you can comment on or make changes to this bug.