| Summary: | HTMLElement.cpp does not compile with new clang | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
| Component: | DOM | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, cfleizach, commit-queue, dbates, eae, esprehn+autocc, gyuyoung.kim, krit, mihnea | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 237736 [details]
Patch v1
Comment on attachment 237736 [details] Patch v1 Clearing flags on attachment: 237736 Committed r173355: <http://trac.webkit.org/changeset/173355> All reviewed patches have been landed. Closing bug. |
HTMLElement.cpp fails to build with new clang: Source/WebCore/html/HTMLElement.cpp:545:10: error: 'this' pointer cannot be null in well-defined C++ code; pointer may be assumed to always convert to true [-Werror,-Wundefined-bool-conversion] if (!this || !parentNode()) ~^~~~ 1 error generated. The |!this| check was added in <http://trac.webkit.org/r75738>.