Bug 136586

Summary:

Add bots to Apple build/test queues

Product:

WebKit

Reporter:

Lucas Forschler <lforschler>

Component:

Tools / Tests

Assignee:

Lucas Forschler <lforschler>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dbates

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
v1 patch to add 6 bots	dbates: review+, dbates: commit-queue-
v2, with a ChangeLog this time.	none
v3 with updated ChangeLog/bug title	dbates: review+, dbates: commit-queue-
v4, ftw?	dbates: review+
one more	none

Lucas Forschler

Reported 2014-09-05 14:35:31 PDT

This should help out with build/test times.

Attachments
v1 patch to add 6 bots (4.97 KB, patch) 2014-09-05 14:36 PDT, Lucas Forschler	dbates: review+ dbates: commit-queue-	Details Formatted Diff Diff
v2, with a ChangeLog this time. (5.54 KB, patch) 2014-09-05 14:43 PDT, Lucas Forschler	no flags	Details Formatted Diff Diff
v3 with updated ChangeLog/bug title (5.42 KB, patch) 2014-09-05 14:51 PDT, Lucas Forschler	dbates: review+ dbates: commit-queue-	Details Formatted Diff Diff
v4, ftw? (5.43 KB, patch) 2014-09-05 15:05 PDT, Lucas Forschler	dbates: review+	Details Formatted Diff Diff
one more (5.43 KB, patch) 2014-09-05 16:01 PDT, Lucas Forschler	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Lucas Forschler

Comment 1 2014-09-05 14:36:18 PDT

Created attachment 237710 [details] v1 patch to add 6 bots

Daniel Bates

Comment 2 2014-09-05 14:38:23 PDT

Comment on attachment 237710 [details] v1 patch to add 6 bots Looks sane to me.

Daniel Bates

Comment 3 2014-09-05 14:40:03 PDT

Comment on attachment 237710 [details] v1 patch to add 6 bots cq-; Missing ChangeLog entry.

Daniel Bates

Comment 4 2014-09-05 14:42:59 PDT

Comment on attachment 237710 [details] v1 patch to add 6 bots View in context: https://bugs.webkit.org/attachment.cgi?id=237710&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:17 > + { "name": "apple-mac-121", "platform": "mac-mountainlion"}, > + { "name": "apple-mac-122", "platform": "mac-mountainlion"}, > + { "name": "apple-mac-123", "platform": "mac-mountainlion"}, Please put these in sorted order. > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:33 > + { "name": "apple-mac-124", "platform": "mac-mavericks" }, > + { "name": "apple-mac-125", "platform": "mac-mavericks" }, > + { "name": "apple-mac-126", "platform": "mac-mavericks" }, Ditto. > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:71 > + "slavenames": ["apple-mini-204", "apple-mac-121"] Ditto. > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:88 > + "slavenames": ["apple-mini-208", "apple-mac-122"] Ditto. > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:92 > + "slavenames": ["apple-mini-209", "apple-mac-123"] Ditto. > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:118 > + "slavenames": ["apple-mini-212", "apple-mac-124"] Ditto. > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:123 > + "slavenames": ["apple-mini-129", "apple-mac-125"] Ditto. > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:127 > + "slavenames": ["apple-mini-130", "apple-mac-126"] Ditto.

Lucas Forschler

Comment 5 2014-09-05 14:43:58 PDT

Created attachment 237711 [details] v2, with a ChangeLog this time.

Lucas Forschler

Comment 6 2014-09-05 14:51:59 PDT

Created attachment 237712 [details] v3 with updated ChangeLog/bug title

Daniel Bates

Comment 7 2014-09-05 14:59:41 PDT

Comment on attachment 237712 [details] v3 with updated ChangeLog/bug title View in context: https://bugs.webkit.org/attachment.cgi?id=237712&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:6 > + { "name": "apple-mac-121", "platform": "mac-mountainlion"}, > + { "name": "apple-mac-122", "platform": "mac-mountainlion"}, > + { "name": "apple-mac-123", "platform": "mac-mountainlion"}, This is OK as-is. We are inconsistent in how we align the "platform" in each line. For instance, on line 16 <http://trac.webkit.org/browser/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json?rev=170172#L16> we add space characters before "platform" such that its aligned with the "platform" in lines above and below it until the definition for the Windows bots. We should pick a style convention for writing these arrays of dictionaries and stick with it throughout this file. > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:71 > + "slavenames": ["apple-mini-204", "apple-mac-121"] Can we swap the files in this array such that the string literals are in sorted order? > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:88 > + "slavenames": ["apple-mini-208", "apple-mac-122"] Ditto. > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:123 > + "slavenames": ["apple-mini-129", "apple-mac-125"] Ditto. > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:127 > + "slavenames": ["apple-mini-130", "apple-mac-126"] Ditto.

Daniel Bates

Comment 8 2014-09-05 15:01:31 PDT

(In reply to comment #7) > > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:71 > > + "slavenames": ["apple-mini-204", "apple-mac-121"] > > Can we swap the files in this array such that the string literals are in sorted order? *string literals

Lucas Forschler

Comment 9 2014-09-05 15:05:25 PDT

Created attachment 237713 [details] v4, ftw?

Daniel Bates

Comment 10 2014-09-05 15:23:12 PDT

Comment on attachment 237713 [details] v4, ftw? View in context: https://bugs.webkit.org/attachment.cgi?id=237713&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:123 > + "slavenames": ["apple-mini-129", "apple-mac-125"] Nit: Swap the order of the string literals such that they are in sorted order.

Lucas Forschler

Comment 11 2014-09-05 16:01:42 PDT

Created attachment 237718 [details] one more

Daniel Bates

Comment 12 2014-09-05 16:05:22 PDT

Comment on attachment 237718 [details] one more Thank you Lucas for updating the patch. It looks beautiful.

WebKit Commit Bot

Comment 13 2014-09-05 16:40:34 PDT

Comment on attachment 237718 [details] one more Clearing flags on attachment: 237718 Committed r173341: <http://trac.webkit.org/changeset/173341>

WebKit Commit Bot

Comment 14 2014-09-05 16:40:36 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.