Summary: | Add bots to Apple build/test queues | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Lucas Forschler <lforschler> | ||||||||||||
Component: | Tools / Tests | Assignee: | Lucas Forschler <lforschler> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | commit-queue, dbates | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Lucas Forschler
2014-09-05 14:35:31 PDT
Created attachment 237710 [details]
v1 patch to add 6 bots
Comment on attachment 237710 [details]
v1 patch to add 6 bots
Looks sane to me.
Comment on attachment 237710 [details]
v1 patch to add 6 bots
cq-; Missing ChangeLog entry.
Comment on attachment 237710 [details] v1 patch to add 6 bots View in context: https://bugs.webkit.org/attachment.cgi?id=237710&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:17 > + { "name": "apple-mac-121", "platform": "mac-mountainlion"}, > + { "name": "apple-mac-122", "platform": "mac-mountainlion"}, > + { "name": "apple-mac-123", "platform": "mac-mountainlion"}, Please put these in sorted order. > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:33 > + { "name": "apple-mac-124", "platform": "mac-mavericks" }, > + { "name": "apple-mac-125", "platform": "mac-mavericks" }, > + { "name": "apple-mac-126", "platform": "mac-mavericks" }, Ditto. > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:71 > + "slavenames": ["apple-mini-204", "apple-mac-121"] Ditto. > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:88 > + "slavenames": ["apple-mini-208", "apple-mac-122"] Ditto. > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:92 > + "slavenames": ["apple-mini-209", "apple-mac-123"] Ditto. > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:118 > + "slavenames": ["apple-mini-212", "apple-mac-124"] Ditto. > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:123 > + "slavenames": ["apple-mini-129", "apple-mac-125"] Ditto. > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:127 > + "slavenames": ["apple-mini-130", "apple-mac-126"] Ditto. Created attachment 237711 [details]
v2, with a ChangeLog this time.
Created attachment 237712 [details]
v3 with updated ChangeLog/bug title
Comment on attachment 237712 [details] v3 with updated ChangeLog/bug title View in context: https://bugs.webkit.org/attachment.cgi?id=237712&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:6 > + { "name": "apple-mac-121", "platform": "mac-mountainlion"}, > + { "name": "apple-mac-122", "platform": "mac-mountainlion"}, > + { "name": "apple-mac-123", "platform": "mac-mountainlion"}, This is OK as-is. We are inconsistent in how we align the "platform" in each line. For instance, on line 16 <http://trac.webkit.org/browser/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json?rev=170172#L16> we add space characters before "platform" such that its aligned with the "platform" in lines above and below it until the definition for the Windows bots. We should pick a style convention for writing these arrays of dictionaries and stick with it throughout this file. > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:71 > + "slavenames": ["apple-mini-204", "apple-mac-121"] Can we swap the files in this array such that the string literals are in sorted order? > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:88 > + "slavenames": ["apple-mini-208", "apple-mac-122"] Ditto. > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:123 > + "slavenames": ["apple-mini-129", "apple-mac-125"] Ditto. > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:127 > + "slavenames": ["apple-mini-130", "apple-mac-126"] Ditto. (In reply to comment #7) > > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:71 > > + "slavenames": ["apple-mini-204", "apple-mac-121"] > > Can we swap the files in this array such that the string literals are in sorted order? *string literals Created attachment 237713 [details]
v4, ftw?
Comment on attachment 237713 [details] v4, ftw? View in context: https://bugs.webkit.org/attachment.cgi?id=237713&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:123 > + "slavenames": ["apple-mini-129", "apple-mac-125"] Nit: Swap the order of the string literals such that they are in sorted order. Created attachment 237718 [details]
one more
Comment on attachment 237718 [details]
one more
Thank you Lucas for updating the patch. It looks beautiful.
Comment on attachment 237718 [details] one more Clearing flags on attachment: 237718 Committed r173341: <http://trac.webkit.org/changeset/173341> All reviewed patches have been landed. Closing bug. |