Bug 136585

Summary: Remove statically used varyings from packing restrictions check
Product: WebKit Reporter: Roger Fong <roger_fong>
Component: WebGLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: bfulgham, commit-queue, dino, jonlee, kondapallykalyan, roger_fong
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 136597    
Bug Blocks:    
Attachments:
Description Flags
patch dino: review+

Description Roger Fong 2014-09-05 13:55:00 PDT 
When checking packing restrictions on a shader's varyings, make sure to not include statically used varyings.

Note that this was the reason why blink was passing this test and webkit was not. They were filtering out these statically used varyings before calling the packing restrictions check.
Comment 1 Roger Fong 2014-09-05 14:06:21 PDT 
Created attachment 237709 [details]
patch
Comment 2 WebKit Commit Bot 2014-09-05 14:08:31 PDT 
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Roger Fong 2014-09-05 15:12:02 PDT 
http://trac.webkit.org/changeset/173335
Comment 4 WebKit Commit Bot 2014-09-06 00:04:35 PDT 
Re-opened since this is blocked by bug 136597
Comment 5 Alexey Proskuryakov 2014-09-06 00:06:08 PDT 
This broke webgl/1.0.2/conformance/glsl/misc/shader-varying-packing-restrictions.html, rolling out.

Diff is just a change from PASS to FAIL.
Comment 6 Alexey Proskuryakov 2014-09-11 11:02:56 PDT 
A different fix is being pursued in bug 136734.