Summary: | [SOUP] Implement ResourceResponse::platformSuggestedFilename() when USE(SOUP) is enabled | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pratik Solanki <psolanki> | ||||
Component: | Platform | Assignee: | Carlos Alberto Lopez Perez <clopez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | benjamin, berto, cdumez, cgarcia, clopez, commit-queue, danw, gustavo, gyuyoung.kim, mrobinson, pnormand, psolanki, svillar | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Pratik Solanki
2014-09-04 18:32:59 PDT
Stub implementation landed in https://trac.webkit.org/r173301 r173272 introduced two new layout test failures on the GTK port: http/tests/download/basic-ascii.html [ Failure ] http/tests/download/literal-utf-8.html [ Failure ] Diffs here: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r173306%20%282554%29/http/tests/download/ I'm updating the GTK TestExpectations and assigning this bug to such failures since I think that fixing this bug will fix also both tests. r173272 has also caused failures on the GTK API tests: TestWebKitAPI/WebKit2Gtk/TestDownloads TestWebKitAPI/WebKit2Gtk/TestResources $ Tools/Scripts/run-gtk-tests --verbose --release WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestDownloads WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestResources TEST: WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestDownloads... (pid=2457) /webkit2/Downloads/local-file: OK /webkit2/Downloads/local-file-error: OK /webkit2/Downloads/remote-file: ** ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:172:void DownloadTest::checkDestinationAndDeleteFile(WebKitDownload*, const char*): assertion failed (destBasename.get() == expectedName): ("test.pdf" == "webkit-downloaded-file") FAIL GTester: last random seed: R02S411e3b1c5da1feafced3b6bd5721a40f (pid=2521) /webkit2/Downloads/remote-file-error: OK /webkit2/Downloads/policy-decision-download: OK /webkit2/WebKitWebView/download-uri: OK FAIL: WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestDownloads TEST: WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestResources... (pid=2548) /webkit2/WebKitWebView/resources: OK /webkit2/WebKitWebView/history-cache: OK /webkit2/WebKitWebResource/loading: OK /webkit2/WebKitWebResource/response: OK /webkit2/WebKitWebResource/mime-type: OK /webkit2/WebKitWebResource/suggested-filename: ** ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:431:void testWebResourceSuggestedFilename(SingleResourceLoadTest*, gconstpointer): assertion failed (webkit_uri_response_get_suggested_filename(response) == "JavaScript.js"): (NULL == "JavaScript.js") FAIL GTester: last random seed: R02Sa97354273c64dd60f7d30bb2ec4a95b7 (pid=2574) /webkit2/WebKitWebResource/active-uri: OK /webkit2/WebKitWebResource/get-data: OK /webkit2/WebKitWebPage/send-request: OK FAIL: WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestResources Tests failed (2): WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestDownloads, WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestResources I'm assigning this bug also to such failures. Updated GTK TestExpectations and list of API Skipped tests on http://trac.webkit.org/changeset/173319 Created attachment 237706 [details]
Patch
Comment on attachment 237706 [details] Patch Clearing flags on attachment: 237706 Committed r173331: <http://trac.webkit.org/changeset/173331> All reviewed patches have been landed. Closing bug. |