Bug 136561

Summary: Add some logging to help diagnose assertions in dumpWebViewAsPixelsAndCompareWithExpected() on bots
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Description Simon Fraser (smfr) 2014-09-04 17:49:33 PDT 
Add some logging to help diagnose assertions in dumpWebViewAsPixelsAndCompareWithExpected() on bots
Comment 1 Simon Fraser (smfr) 2014-09-04 17:50:07 PDT 
Created attachment 237663 [details]
Patch
Comment 2 Tim Horton 2014-09-04 17:51:18 PDT 
Comment on attachment 237663 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237663&action=review

> Tools/DumpRenderTree/mac/PixelDumpSupportMac.mm:58
> +        WTFLogAlways("calloc(%llu, %llu) failed\n", pixelsHigh, rowBytes);

Can we throw a note in here about where these are coming from? ("DumpRenderTree: calloc...").
Comment 3 Simon Fraser (smfr) 2014-09-04 17:55:39 PDT 
https://trac.webkit.org/r173297
Comment 4 Alexey Proskuryakov 2014-09-10 12:45:33 PDT 
It says: 
DumpRenderTree: calloc(18446744073709551595, 64) failed

http://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK1%20(Tests)/r173475%20(7561)/fast/regions/auto-size/autosize-region-window-resize-stderr.txt

18446744073709551595 is 0x7FFFFFFFFFFFFFFF
Comment 5 Simon Fraser (smfr) 2014-09-10 13:29:41 PDT 
Yeah. I should have logged height and width.