Bug 136552

Summary: Fix FIXME's in JSTrackCustom now that AudioTrack and VideoTrack exist.
Product: WebKit Reporter: Brendan Long <b.long>
Component: MediaAssignee: Brendan Long <b.long>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, jer.noble, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Brendan Long
Reported 2014-09-04 15:45:51 PDT
Fix FIXME's in JSTrackCustom not that AudioTrack and VideoTrack exist.
Attachments
Patch (1.58 KB, patch)
2014-09-04 15:47 PDT, Brendan Long 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brendan Long
Comment 1 2014-09-04 15:47:18 PDT
Created attachment 237652 [details] Patch
Brendan Long
Comment 2 2014-09-04 15:48:08 PDT
I saw this FIXME while I was working on another patch. I'm not really sure how this code is used though. Is there some way I could test this?
Eric Carlson
Comment 3 2014-09-05 09:52:56 PDT
(In reply to comment #2) > I saw this FIXME while I was working on another patch. I'm not really sure how this code is used though. Is there some way I could test this? I think toTrack() is only used by JSDictionary::convertValue() currently, and I believe that is only used when MediaStream is enabled so you can't test it at the moment.
Eric Carlson
Comment 4 2014-09-05 09:58:58 PDT
(In reply to comment #3) > (In reply to comment #2) > > I saw this FIXME while I was working on another patch. I'm not really sure how this code is used though. Is there some way I could test this? > > I think toTrack() is only used by JSDictionary::convertValue() currently, and I believe that is only used when MediaStream is enabled so you can't test it at the moment. Scratch that, it can also be used for a TrackEvent. But I am still not sure how you would test it.
Brendan Long
Comment 5 2014-09-10 15:32:32 PDT
Sorry, got distracted by some other stuff. Do you think we should apply this fix, or should we wait until we have some way to test it?
Eric Carlson
Comment 6 2014-09-10 16:40:56 PDT
(In reply to comment #5) > Sorry, got distracted by some other stuff. Do you think we should apply this fix, or should we wait until we have some way to test it? Why don't you land it, the new code is obviously better than what we have now.
WebKit Commit Bot
Comment 7 2014-09-11 08:03:56 PDT
Comment on attachment 237652 [details] Patch Clearing flags on attachment: 237652 Committed r173513: <http://trac.webkit.org/changeset/173513>
WebKit Commit Bot
Comment 8 2014-09-11 08:04:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.