Bug 136534

Summary:

Remove ResourceResponse::m_suggestedFilename

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Page Loading

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue, gyuyoung.kim, japhet, mitz, psolanki, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

136573

Bug Blocks:

Attachments:

Description	Flags
patch	ap: review+
for bots	none

Antti Koivisto

Reported 2014-09-04 09:57:21 PDT

It is complicating things.

Attachments
patch (26.71 KB, patch) 2014-09-04 10:18 PDT, Antti Koivisto	ap: review+	Details Formatted Diff Diff
for bots (27.12 KB, patch) 2014-09-04 11:48 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2014-09-04 10:18:44 PDT

Created attachment 237630 [details] patch

WebKit Commit Bot

Comment 2 2014-09-04 10:19:32 PDT

Attachment 237630 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/ResourceResponseBase.h:135: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alexey Proskuryakov

Comment 3 2014-09-04 10:46:46 PDT

Comment on attachment 237630 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=237630&action=review r=me. > Source/WebCore/platform/network/mac/ResourceResponseMac.mm:62 > + for (const auto& header : m_httpHeaderFields) I think that "auto&" is all the rage these days, not "const auto&". > Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:812 > + auto* headers = [NSMutableDictionary dictionaryWithObjectsAndKeys: I think that we can and should use @{} here, there seems to be no reason for the dictionary to be mutable.

Pratik Solanki

Comment 4 2014-09-04 10:47:55 PDT

Comment on attachment 237630 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=237630&action=review > Source/WebCore/platform/network/mac/ResourceResponseMac.mm:172 > +String ResourceResponse::platformSuggestedFilename() const You need an implementation for this function on the CFNetwork side as well. CFURLResponseCopySuggestedFilename is the function to call.

Antti Koivisto

Comment 5 2014-09-04 11:48:09 PDT

Created attachment 237634 [details] for bots

Antti Koivisto

Comment 6 2014-09-04 13:00:43 PDT

https://trac.webkit.org/r173272

Gyuyoung Kim

Comment 7 2014-09-04 17:50:57 PDT

(In reply to comment #6) > https://trac.webkit.org/r173272 EFL and GTK ports have been broken since r173272. http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20%28Build%29/builds/45053

Pratik Solanki

Comment 8 2014-09-04 17:58:38 PDT

Just removing the last argument (filename) in soup/ResourceReponse.h should fix the error I think.