| Summary: | Remove ResourceResponse::m_suggestedFilename | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||
| Component: | Page Loading | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ap, commit-queue, gyuyoung.kim, japhet, mitz, psolanki, simon.fraser | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 136573 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Antti Koivisto
2014-09-04 09:57:21 PDT
Created attachment 237630 [details]
patch
Attachment 237630 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/network/ResourceResponseBase.h:135: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 13 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 237630 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=237630&action=review r=me. > Source/WebCore/platform/network/mac/ResourceResponseMac.mm:62 > + for (const auto& header : m_httpHeaderFields) I think that "auto&" is all the rage these days, not "const auto&". > Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:812 > + auto* headers = [NSMutableDictionary dictionaryWithObjectsAndKeys: I think that we can and should use @{} here, there seems to be no reason for the dictionary to be mutable. Comment on attachment 237630 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=237630&action=review > Source/WebCore/platform/network/mac/ResourceResponseMac.mm:172 > +String ResourceResponse::platformSuggestedFilename() const You need an implementation for this function on the CFNetwork side as well. CFURLResponseCopySuggestedFilename is the function to call. Created attachment 237634 [details]
for bots
(In reply to comment #6) > https://trac.webkit.org/r173272 EFL and GTK ports have been broken since r173272. http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20%28Build%29/builds/45053 Just removing the last argument (filename) in soup/ResourceReponse.h should fix the error I think. Checked in a speculative build fix in https://trac.webkit.org/r173300 Another one - https://trac.webkit.org/r173301 Finally I fixed build break on r173305 http://trac.webkit.org/changeset/173305 Two blob tests have been consistently failing after this commit: http://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK1%20(Tests)/r173272%20(7445)/results.html GTK port needed one more fix - http://trac.webkit.org/changeset/173306 Bug 136573 for the blob issue. (In reply to comment #6) > https://trac.webkit.org/r173272 This caused bug 137239. |