Bug 13650

Summary: Gdk port needs ImageBuffer implementation (build fixlets)
Product: WebKit Reporter: Holger Freyther <zecke>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mrowe
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: PC   
OS: OS X 10.4   
Attachments:
Description Flags
gdk build fixlet
mrowe: review+
Implement ImagebufferCairo using ciaro_image_surface none

Holger Freyther
Reported 2007-05-09 13:21:02 PDT
To make the Gdk port (compiled with qmake) link an Implementation of ImageBuffer is needed. This report adds a stub and fixes a newbie issue.
Attachments
gdk build fixlet (4.26 KB, patch)
2007-05-09 13:31 PDT, Holger Freyther 		mrowe: review+
DetailsFormatted DiffDiff
Implement ImagebufferCairo using ciaro_image_surface (3.26 KB, patch)
2007-05-10 07:36 PDT, Holger Freyther 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Holger Freyther
Comment 1 2007-05-09 13:31:32 PDT
Created attachment 14438 [details] gdk build fixlet -Add ImageBuffer stubs for cairo -Always include config.h. Sorry for the newbie error.
Mark Rowe (bdash)
Comment 2 2007-05-09 15:00:04 PDT
Comment on attachment 14438 [details] gdk build fixlet There are a few minor formatting issues with this patch, but I'll fix those as I land it.
Mark Rowe (bdash)
Comment 3 2007-05-09 15:04:42 PDT
Landed in r21340.
Holger Freyther
Comment 4 2007-05-10 07:36:25 PDT
Created attachment 14465 [details] Implement ImagebufferCairo using ciaro_image_surface Now an untested ImageBufferCairo implementation. Sadly it is untested as there is no easy way to test the platform/graphics classes.
Holger Freyther
Comment 5 2007-05-10 07:37:07 PDT
New patch => reopening
Mark Rowe (bdash)
Comment 6 2007-05-10 21:01:50 PDT
Holger, we don't reuse bugs for new patches. Can you please file a new bug specifically relating to your new patch and attach the patch to it?
Note You need to log in before you can comment on or make changes to this bug.