Bug 136493

Summary: [Win] Improper release of unretained AVCFAssetResourceLoaderRef
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: MediaAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Blocker CC: bfulgham, commit-queue, eric.carlson, glenn, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch eric.carlson: review+

Brent Fulgham
Reported 2014-09-03 12:42:22 PDT
The return value of AVCFURLAssetGetResourceLoader is being adopted by a RetainPtr. This is wrong for a couple of reasons: 1. We use the return value as an argument to another API call, and are not seeking to hold ownership. So the RetainPtr is not necessary and just adds overhead. 2. Since we adopt the argument, we don't increment the reference count. Per Get/Copy/Create semantics, the return value of AVCFURLAssetGetResourceLoader does not have its retain count incremented, so it is inappropriate to release this value.
Attachments
Patch (2.07 KB, patch)
2014-09-03 12:46 PDT, Brent Fulgham 		eric.carlson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2014-09-03 12:42:52 PDT
<rdar://problem/18112559>
Brent Fulgham
Comment 2 2014-09-03 12:46:50 PDT
Created attachment 237571 [details] Patch
Brent Fulgham
Comment 3 2014-09-03 12:59:05 PDT
Committed in r173218. <http://trac.webkit.org/changeset/173218>
Note You need to log in before you can comment on or make changes to this bug.