[GTK] run-webkit-test check for jhBuild is not correct

• Component: Tools / Tests
• Status: RESOLVED INVALID

[Fabien Vallée]

Tools/Scripts/webkitpy/port/gtk.py is checking if tests must be run within jhBuild wrapper. 
If webkit/WebKitBuild/Dependencies exists, tests are run using jhBuild wrapper - it works fine using default configuration, however it has 2 issues:

1) WebKitBuild/Dependencies exists even if jhBuild is not used, because it is needed for fonts (as you can see in getFontsPath() method from http://trac.webkit.org/browser/trunk/Tools/WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp)
So a build using default WebKitBuild folder but NOT using jhBuild will be using jhBuild wrapper anyway (and jhBuild checkout during tests mess up everything).

2) build folder (default is webkit/WebKitBuild) can be overridden using WEBKIT_OUTPUTDIR env variable. In that case jhBuild is never detected and regression tests will fail (tests are using system libs instead of jhBuild)

[Fabien Vallée]

Created attachment 237551 [details]
Patch

[Philippe Normand]

(In reply to comment #0)
> Tools/Scripts/webkitpy/port/gtk.py is checking if tests must be run within jhBuild wrapper. 
> If webkit/WebKitBuild/Dependencies exists, tests are run using jhBuild wrapper - it works fine using default configuration, however it has 2 issues:
> 
> 1) WebKitBuild/Dependencies exists even if jhBuild is not used, because it is needed for fonts (as you can see in getFontsPath() method from http://trac.webkit.org/browser/trunk/Tools/WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp)
> So a build using default WebKitBuild folder but NOT using jhBuild will be using jhBuild wrapper anyway (and jhBuild checkout during tests mess up everything).
> 

But if you set WEBKIT_OUTPUTDIR and don't have Dependencies/ that function will look for fonts in WEBKIT_OUTPUTDIR, or am I misunderstanding that code?

[Fabien Vallée]

You are 100% right. Fonts don't need to be in WebKitBuild/Dependencies anymore, so please forget 1).

(sorry for that. Got that issue long time ago because DumpRenderTree was printing error message "Could not locate test fonts at $WEBKIT_TOP_LEVEL/WebKitBuild/Dependencies/Root/webkitgtk-test-fonts", but WebKitTestRunner works fine w/ fonts directly in $WEBKIT_TOP_LEVEL/WebKitBuild or in $WEBKIT_OUTPUTDIR).

I will upload a new patch (first was not working anyway) for review with the WEBKIT_OUTPUTDIR check in gtk.py.

[Fabien Vallée]

bug can be closed. Issue has been fixed already
http://trac.webkit.org/changeset/172830

(os.path.exists(self.path_from_webkit_base('WebKitBuild', 'Dependencies')): has been replaced by self._should_use_jhbuild())

[Philippe Normand]

Comment on attachment 237551 [details]
Patch

Removing patch from review queue