Bug 136453

Summary: [CSS Grid Layout] Handle percentages of indefinite sizes in minmax() and grid-auto-*
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: New BugsAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, buildbot, commit-queue, darin, dbates, esprehn+autocc, glenn, jfernandez, kling, kondapallykalyan, rego, rhodovan.u-szeged, rniwa, svillar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60731    
Attachments:
Description Flags
Patch
darin: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 none

Description Sergio Villar Senin 2014-09-02 08:50:32 PDT 
[CSS Grid Layout] Handle percentages of indefinite sizes in minmax() and grid-auto-*
Comment 1 Sergio Villar Senin 2014-09-02 09:13:05 PDT 
Created attachment 237491 [details]
Patch
Comment 2 Build Bot 2014-09-02 14:30:59 PDT 
Comment on attachment 237491 [details]
Patch

Attachment 237491 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5889874787827712

New failing tests:
animations/3d/transform-origin-vs-functions.html
animations/3d/matrix-transform-type-animation.html
animations/3d/state-at-end-event-transform.html
canvas/philip/tests/2d.canvas.reference.html
canvas/philip/tests/2d.clearRect+fillRect.basic.html
canvas/philip/tests/2d.clearRect+fillRect.alpha0.5.html
animations/3d/replace-filling-transform.html
canvas/philip/tests/2d.clearRect+fillRect.alpha0.html
Comment 3 Build Bot 2014-09-02 14:31:02 PDT 
Created attachment 237515 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 4 Sergio Villar Senin 2014-09-23 02:14:03 PDT 
(In reply to comment #3)
> Created an attachment (id=237515) [details]
> Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2
> 
> The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
> Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

Totally unrelated
Comment 5 Sergio Villar Senin 2014-09-23 07:15:13 PDT 
*** Bug 136940 has been marked as a duplicate of this bug. ***
Comment 6 Sergio Villar Senin 2014-09-23 07:43:09 PDT 
Gentle reminder...
Comment 7 Darin Adler 2014-09-28 18:03:07 PDT 
Comment on attachment 237491 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237491&action=review

> Source/WebCore/rendering/RenderGrid.cpp:303
> +        GridTrackSize trackSize = gridTrackSize(direction, i);

A return value of type GridTrackSize can go into a local variable of const GridTrackSize& and gets an appropriate lifetime. So these changes, while OK, are not needed.

> Source/WebCore/rendering/RenderGrid.cpp:471
> +    const Vector<GridTrackSize>& trackStyles =  isForColumns ? style().gridColumns() : style().gridRows();

Seems like a good place to do auto&.

> Source/WebCore/rendering/RenderGrid.cpp:472
> +    const GridTrackSize& trackSize = (i >= trackStyles.size()) ? (isForColumns ? style().gridAutoColumns() : style().gridAutoRows()) : trackStyles[i];

Seems like a good place to do auto&.
Comment 8 Sergio Villar Senin 2014-09-29 03:08:50 PDT 
Committed r174057: <http://trac.webkit.org/changeset/174057>