Bug 136442

Summary:

check-webkit-style is confused by ternary expression inside first member initializer

Product:

WebKit

Reporter:

Brian Burg <burg>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, glenn, llango.u-szeged, ossy, rnagy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	none
Proposed patch	none

Description Brian Burg 2014-09-01 18:08:53 PDT

Test case:

ProfileGenerator::ProfileGenerator(ExecState* exec, const String&, unsigned)
    : m_origin(exec ? exec->lexicalGlobalObject() : nullptr)
    , m_profileGroup(exec ? exec->lexicalGlobalObject()->profileGroup() : 0)
    , m_foundConsoleStartParent(false)
{
}

Comment 1 Nagy Renátó 2014-09-09 01:48:22 PDT

Created attachment 237844 [details]
Proposed patch

Comment 2 Nagy Renátó 2014-09-09 02:27:33 PDT

Created attachment 237845 [details]
Proposed patch

Fix missing unittests.

Comment 3 WebKit Commit Bot 2014-12-03 05:31:34 PST

Comment on attachment 237845 [details]
Proposed patch

Clearing flags on attachment: 237845

Committed r176718: <http://trac.webkit.org/changeset/176718>

Comment 4 WebKit Commit Bot 2014-12-03 05:31:38 PST

All reviewed patches have been landed.  Closing bug.