Summary: | [WinCairo] Memory cache capacity is not set. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | peavo | ||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | alex.christensen, bfulgham, commit-queue | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
peavo
2014-09-01 11:06:38 PDT
Created attachment 237456 [details]
Patch
Should there be curl equivalents of CFURLSetMemoryCapacity and CFURLSetDiskCapacity? Created attachment 237501 [details]
Patch
(In reply to comment #2) > Should there be curl equivalents of CFURLSetMemoryCapacity and CFURLSetDiskCapacity? Thanks for reviewing, updated patch with curl equivalent of CFURLSetDiskCapacity. I don't think there is something similar for CFURLSetMemoryCapacity. This looks good to me. I'm not sure if WinCairo even has something like the CFURL cache, though. Brent, do you know? Comment on attachment 237501 [details]
Patch
CFURLCacheSetMemoryCapacity and CFURLCacheSetDiskCapacity seem to be undocumented :(
CurlCacheManager::setStorageSizeLimit just changes m_storageSizeLimit, which defaults to 50MB but this could increase it to 175MB if there is an incredible amount of space on the disk. This seems ok to me.
Comment on attachment 237501 [details] Patch Clearing flags on attachment: 237501 Committed r173200: <http://trac.webkit.org/changeset/173200> All reviewed patches have been landed. Closing bug. (In reply to comment #6) > (From update of attachment 237501 [details]) > CFURLCacheSetMemoryCapacity and CFURLCacheSetDiskCapacity seem to be undocumented :( > > CurlCacheManager::setStorageSizeLimit just changes m_storageSizeLimit, which defaults to 50MB but this could increase it to 175MB if there is an incredible amount of space on the disk. This seems ok to me. Thanks! Note: This broke the Apple Windows build because it expected cacheMemoryCapacity (and cacheDiskCapacity) to be CFIndex type. Fixed in <http://trac.webkit.org/changeset/173207>. (In reply to comment #10) > Note: This broke the Apple Windows build because it expected cacheMemoryCapacity (and cacheDiskCapacity) to be CFIndex type. Fixed in <http://trac.webkit.org/changeset/173207>. Thanks for fixing it, and sorry for the inconvenience ... |