Bug 136395

Summary:

Need a way to get userAgent from WKWebView.

Product:

WebKit

Reporter:

Yongjun Zhang <yongjun_zhang>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, buildbot, commit-queue, mitz, rniwa, sam, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch. Add _userAgent property for WKWebView.	none
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2	none
reload the patch and try again, since it is not related with the layout test fails.	none

Yongjun Zhang

Reported 2014-08-29 16:52:52 PDT

I would be nice to have a property/method to return userAgent string from an WKWebView.

Attachments
Patch. Add _userAgent property for WKWebView. (1.95 KB, patch) 2014-08-29 17:15 PDT, Yongjun Zhang	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (840.05 KB, application/zip) 2014-08-29 18:32 PDT, Build Bot	no flags	Details
reload the patch and try again, since it is not related with the layout test fails. (1.95 KB, patch) 2014-09-02 09:58 PDT, Yongjun Zhang	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Yongjun Zhang

Comment 1 2014-08-29 17:15:24 PDT

Created attachment 237392 [details] Patch. Add _userAgent property for WKWebView.

Build Bot

Comment 2 2014-08-29 18:32:34 PDT

Comment on attachment 237392 [details] Patch. Add _userAgent property for WKWebView. Attachment 237392 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6102750010015744 New failing tests: animations/3d/transform-origin-vs-functions.html animations/animation-border-overflow.html http/tests/appcache/abort-cache-onchecking.html http/tests/appcache/abort-cache-onchecking-resource-404.html http/tests/appcache/abort-cache-onchecking-manifest-404.html animations/animation-add-events-in-handler.html animations/animation-controller-drt-api.html animations/additive-transform-animations.html http/tests/appcache/404-resource.html accessibility/alt-tag-on-image-with-nonimage-role.html

Build Bot

Comment 3 2014-08-29 18:32:36 PDT

Created attachment 237402 [details] Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Yongjun Zhang

Comment 4 2014-09-02 09:58:03 PDT

Created attachment 237499 [details] reload the patch and try again, since it is not related with the layout test fails.

Anders Carlsson

Comment 5 2014-09-02 15:26:06 PDT

Comment on attachment 237499 [details] reload the patch and try again, since it is not related with the layout test fails. Since we can have different user agents for different URLs, would it make sense to make userAgent take an URL?

Yongjun Zhang

Comment 6 2014-09-02 15:53:47 PDT

(In reply to comment #5) > (From update of attachment 237499 [details]) > Since we can have different user agents for different URLs, would it make sense to make userAgent take an URL? For the issue I am currently working on, we just need the default user agent string. It would be nice to have userAgentForURL, but looks like WebPageProxy doesn't have the information, and we would need to add a message to fetch from web process.

WebKit Commit Bot

Comment 7 2014-09-03 14:52:17 PDT

Comment on attachment 237499 [details] reload the patch and try again, since it is not related with the layout test fails. Clearing flags on attachment: 237499 Committed r173233: <http://trac.webkit.org/changeset/173233>

WebKit Commit Bot

Comment 8 2014-09-03 14:52:20 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.