Bug 136389

Summary:

Rename updatePreferredWidth to make it more explicit.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, kondapallykalyan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description zalan 2014-08-29 14:20:33 PDT

from:
static inline void updatePreferredWidth(LayoutUnit& preferredWidth, float& result)

to:
static inline LayoutUnit preferredWidth(LayoutUnit preferredWidth, float result)

Comment 1 zalan 2014-08-29 14:26:39 PDT

Created attachment 237377 [details]
Patch

Comment 2 Simon Fraser (smfr) 2014-08-29 19:13:54 PDT

Comment on attachment 237377 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237377&action=review

> Source/WebCore/rendering/RenderBlock.cpp:2984
> +                    minLogicalWidth = preferredWidth(minLogicalWidth, inlineMin);

It's correct to use fromFloatCeil() even though this is a "min" value?

Comment 3 WebKit Commit Bot 2014-08-29 19:55:12 PDT

Comment on attachment 237377 [details]
Patch

Clearing flags on attachment: 237377

Committed r173134: <http://trac.webkit.org/changeset/173134>

Comment 4 WebKit Commit Bot 2014-08-29 19:55:14 PDT

All reviewed patches have been landed.  Closing bug.