Bug 136363 – [JSC] Some JSC stress tests are dependent on the machine time zone.

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Carlos Alberto Lopez Perez]

I have noticed that some of the JSC stress tests fail if your timezone is not PDT (At least on the GTK port, didn't tested other ports).

They pass all OK if your timezone is PDT:

$ export TZ="US/Pacific"
$ Tools/Scripts/run-javascriptcore-tests --release --gtk --no-build
[...]
9887/9887         

Results for JSC stress tests:
    0 failures found.
    OK.


But some fail if you have another timezone:

$ export TZ="Europe/Madrid"
$ Tools/Scripts/run-javascriptcore-tests --release --gtk --no-build
[...]
9887/9887 (failed 4)         

** The following JSC stress test failures have been introduced:
	mozilla-tests.yaml/ecma_3/Date/15.9.5.6.js.mozilla
	mozilla-tests.yaml/ecma_3/Date/15.9.5.6.js.mozilla-baseline
	mozilla-tests.yaml/ecma_3/Date/15.9.5.6.js.mozilla-dfg-eager-no-cjit-validate-phases
	mozilla-tests.yaml/ecma_3/Date/15.9.5.6.js.mozilla-llint

Results for JSC stress tests:
    4 failures found.



To workaround this, maybe we can just export the environment variable TZ to US/Pacific on the script run-javascriptcore-tests ?

[Andy Wingo]

(In reply to comment #0)
> I have noticed that some of the JSC stress tests fail if your timezone is not PDT (At least on the GTK port, didn't tested other ports).

Yep, a long-standing bug present in these tests since they were imported from Mozilla.  Note that these aren't the main tests for JSC -- those are in LayoutTests.

> To workaround this, maybe we can just export the environment variable TZ to US/Pacific on the script run-javascriptcore-tests ?

Sure, sounds like a good idea to me.

[Csaba Osztrogonác]

It is a very old bug: bug4930 . The workaround for us was always 
to set TZ to Apple time zone if you want to run JSC tests. :)

+1 for adding this workaround if nobody wants to fix the buggy test.

[Csaba Osztrogonác]

Adding $ENV{TZ}="US/Pacific"; to run-javascriptcore-tests works for me,
feel free to create a patch for it.

[Carlos Alberto Lopez Perez]

Created attachment 237347 [details]
Patch

[Csaba Osztrogonác]

Comment on attachment 237347 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237347&action=review

> Tools/Scripts/run-javascriptcore-tests:237
> +    # Some tests fail if the time zone is not set to US/Pacific (<https://webkit.org/b/136363>)
> +    $ENV{TZ}="US/Pacific";

We can apply this if we only run the mozilla tests for some reason.

[Carlos Alberto Lopez Perez]

(In reply to comment #5)
> (From update of attachment 237347 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=237347&action=review
> 
> > Tools/Scripts/run-javascriptcore-tests:237
> > +    # Some tests fail if the time zone is not set to US/Pacific (<https://webkit.org/b/136363>)
> > +    $ENV{TZ}="US/Pacific";
> 
> We can apply this if we only run the mozilla tests for some reason.

Not sure if I understand what you mean. Exporting it inside:

if ($runMozilla) {
[...]
}

Don't fixes the issue.

[Carlos Alberto Lopez Perez]

Also, running "Tools/Scripts/run-javascriptcore-tests [...] --no-jsc-stress" don't fails

[Csaba Osztrogonác]

I meant Tools/Scripts/run-javascriptcore-tests --no-jsc-stress 
case should be workarounded too, not only the stress test case.

[Carlos Alberto Lopez Perez]

I see.

There are some mozilla test skipped due to this issue with the timezone. See r99580 <http://trac.webkit.org/r99580>.

I have tested to unskip them and they fail only with a non US/Pacific timezone, but pass on US/Pacific.

I'm going to unskip this tests and set the TZ environment variable on the main body of the script.

[Carlos Alberto Lopez Perez]

Created attachment 237355 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 237355 [details]
Patch

Clearing flags on attachment: 237355

Committed r173116: <http://trac.webkit.org/changeset/173116>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.