Bug 136348

Summary: Use JSString::toIdentifier() in more places.
Product: WebKit Reporter: Andreas Kling <kling>
Component: JavaScriptCoreAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2 Keywords: Performance
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Andreas Kling
Reported 2014-08-28 13:14:51 PDT
JSString::toIdentifier() avoids allocating a new StringImpl when serializing a rope string into an already-existing Identifier.
Attachments
Patch (9.76 KB, patch)
2014-08-28 13:16 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-08-28 13:16:05 PDT
Created attachment 237324 [details] Patch
Geoffrey Garen
Comment 2 2014-08-28 13:50:29 PDT
Comment on attachment 237324 [details] Patch r=me
WebKit Commit Bot
Comment 3 2014-08-28 14:38:35 PDT
Comment on attachment 237324 [details] Patch Clearing flags on attachment: 237324 Committed r173082: <http://trac.webkit.org/changeset/173082>
WebKit Commit Bot
Comment 4 2014-08-28 14:38:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.