Bug 136341

Summary:

Subpixel layout: Remove unused pixel snapping functions.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

136275

Attachments:

Description	Flags
Patch	none
Patch	none

Description zalan 2014-08-28 08:57:19 PDT

and remove some that's still in use so that we stop using them. (most of them should go away anyway in long run)

Comment 1 zalan 2014-08-28 09:31:02 PDT

Created attachment 237315 [details]
Patch

Comment 2 WebKit Commit Bot 2014-08-28 09:33:36 PDT

Attachment 237315 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderScrollbar.cpp:277:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderScrollbar.cpp:278:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderScrollbar.cpp:284:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderScrollbar.cpp:285:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderScrollbar.cpp:290:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderScrollbar.cpp:291:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderScrollbar.cpp:292:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 7 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 zalan 2014-08-28 11:20:55 PDT

Created attachment 237319 [details]
Patch

Comment 4 WebKit Commit Bot 2014-08-28 11:23:36 PDT

Attachment 237319 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderScrollbar.cpp:277:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderScrollbar.cpp:278:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderScrollbar.cpp:284:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderScrollbar.cpp:285:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderScrollbar.cpp:290:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderScrollbar.cpp:291:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderScrollbar.cpp:292:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 7 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 WebKit Commit Bot 2014-08-28 12:49:03 PDT

Comment on attachment 237319 [details]
Patch

Clearing flags on attachment: 237319

Committed r173073: <http://trac.webkit.org/changeset/173073>

Comment 6 WebKit Commit Bot 2014-08-28 12:49:06 PDT

All reviewed patches have been landed.  Closing bug.