Bug 136323

Summary:

textStylingAtPosition returns incorrect values after executing toggleBold, toggleItalic and toggleUnderline

Product:

WebKit

Reporter:

Enrica Casucci <enrica>

Component:

HTML Editing

Assignee:

Enrica Casucci <enrica>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ddkilzer, koivisto

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	koivisto: review+

Description Enrica Casucci 2014-08-27 17:11:43 PDT

textStylingAtPosition should always reflect the current style. It returns incorrect values when called after executing one of the toggle styling commands.

rdar://problem/18141964

Comment 1 Enrica Casucci 2014-08-27 17:22:06 PDT

Created attachment 237272 [details]
Patch

Comment 2 Antti Koivisto 2014-08-27 17:58:07 PDT

Comment on attachment 237272 [details]
Patch

Looks good.

It would be nice if we could at some point have only one copy of this and perhaps also eliminate the whole insert-and-remove-span-to-figure-out-style hack.

Comment 3 David Kilzer (:ddkilzer) 2015-01-06 12:39:49 PST

Committed revision 173071.
<http://trac.webkit.org/changeset/173071>