| Summary: | WebKit2 swipe gesture should report the position of the snapshot to the client | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
| Component: | WebKit2 | Assignee: | Tim Horton <thorton> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, mitz, simon.fraser | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tim Horton
2014-08-27 14:07:36 PDT
Created attachment 237248 [details]
patch
Attachment 237248 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/mac/PageClientImpl.h:112: The parameter name "layer" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 237248 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=237248&action=review > Source/WebKit2/UIProcess/PageClient.h:234 > + virtual CGRect boundsOfLayerInLayerBackedWindowCoordinates(CALayer *) = 0; const? > Source/WebKit2/UIProcess/WebPageProxy.h:512 > + CGRect boundsOfLayerInLayerBackedWindowCoordinates(CALayer *); const? > Source/WebKit2/UIProcess/mac/PageClientImpl.h:112 > + CGRect boundsOfLayerInLayerBackedWindowCoordinates(CALayer *layer); const? |