Bug 136304

Summary: Deconstruction object pattern node emits the wrong start/end text positions
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, ggaren
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Saam Barati
Reported 2014-08-27 13:28:01 PDT
Consider the program: var {x, y} = {x:20, y:50}; If looking at the start/end positions for the binding nodes representing x and y, they will be wrong. "x"s position will be at the first comma "y"s position will be at the first closing brace. This has to do with Parser::createBindingPattern will consume the location from m_token, but at this point, m_token is on the comma/closing brace. createBindingPattern should probably accept a token as its input for which it will get token location information.
Attachments
patch (5.33 KB, patch)
2014-08-27 14:22 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2014-08-27 14:22:26 PDT
Created attachment 237252 [details] patch Fixes the problem by caching the JSToken before attempting to parse an optional colon.
Geoffrey Garen
Comment 2 2014-08-27 14:57:38 PDT
Comment on attachment 237252 [details] patch r=me
WebKit Commit Bot
Comment 3 2014-08-27 15:34:19 PDT
Comment on attachment 237252 [details] patch Clearing flags on attachment: 237252 Committed r173026: <http://trac.webkit.org/changeset/173026>
WebKit Commit Bot
Comment 4 2014-08-27 15:34:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.