build.webkit.org/dashboard: Poor performance when there are broken builds at initial load time

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Alexey Proskuryakov]

For failing builds, the dashboard tries to figure out how long the build was broken. If it doesn't happen to have the data for an older passing build already loaded, it starts to load all historic results for this revision.

This is extremely costly, as there is an HTTP request for each iteration.

[Alexey Proskuryakov]

Created attachment 237205 [details]
proposed fix

[Alexey Proskuryakov]

Builders are all shamelessly green, so I couldn't test the patch now :)

[Tim Horton]

Comment on attachment 237205 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=237205&action=review

> Tools/ChangeLog:10
> +        the iteration is already beaing loaded.

s/beaing/being/

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:111
> +                    queue.loadMoreHistoricIterations();

historic (adj.): "famous or important in history, or potentially so"

I think you want 'historical'. English is weird.

[Alexey Proskuryakov]

Created attachment 237208 [details]
patch for landing

Thanks!

[WebKit Commit Bot]

Comment on attachment 237208 [details]
patch for landing

Clearing flags on attachment: 237208

Committed r172998: <http://trac.webkit.org/changeset/172998>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.