Bug 136276

Summary: Subpixel layout: Rename pixelSnappedIntRect*() functions to roundedIntRect*().
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED INVALID    
Severity: Normal CC: buildbot, rniwa, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 136275    
Attachments:
Description Flags
Patch
buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2
none
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion
none
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion
none
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion none

Description zalan 2014-08-26 20:18:44 PDT
The term 'pixel snapping' is ambiguous. (CSS pixel vs. device pixel)
Comment 1 zalan 2014-08-26 20:29:28 PDT
Created attachment 237194 [details]
Patch
Comment 2 Build Bot 2014-08-26 21:55:57 PDT
Comment on attachment 237194 [details]
Patch

Attachment 237194 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6747099794243584

New failing tests:
svg/wicd/rightsizing-grid.xhtml
svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml
svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml
svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml
Comment 3 Build Bot 2014-08-26 21:56:00 PDT
Created attachment 237202 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 4 Build Bot 2014-08-26 22:34:29 PDT
Comment on attachment 237194 [details]
Patch

Attachment 237194 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6642936099897344

New failing tests:
svg/wicd/rightsizing-grid.xhtml
svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml
svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml
svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml
Comment 5 Build Bot 2014-08-26 22:34:32 PDT
Created attachment 237204 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 6 Build Bot 2014-08-26 23:38:12 PDT
Comment on attachment 237194 [details]
Patch

Attachment 237194 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5834621107306496

New failing tests:
svg/wicd/rightsizing-grid.xhtml
svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml
svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml
svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml
Comment 7 Build Bot 2014-08-26 23:38:15 PDT
Created attachment 237209 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 8 Build Bot 2014-08-27 00:32:31 PDT
Comment on attachment 237194 [details]
Patch

Attachment 237194 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4997083425669120

New failing tests:
svg/wicd/rightsizing-grid.xhtml
svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml
svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml
svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml
Comment 9 Build Bot 2014-08-27 00:32:34 PDT
Created attachment 237214 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 10 zalan 2014-08-27 21:03:20 PDT
fixed in bug #136314