Subpixel layout: Cleanup snapSizeToPixel/snapSizeToDevicePixel.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[zalan]

Pixel in the function name (without specifying whether its a device or CSS pixel) is misleading.

[zalan]

Created attachment 237166 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 237166 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237166&action=review

r- because snapSize with a local point is meaningless.

> Source/WebCore/platform/LayoutUnit.h:919
> +inline int snapSizeToInt(LayoutUnit size, LayoutUnit location)

Three things make me sad about this. "snap" outside of pixel snapping, "size" which is not a LayoutSize and "location" that is not a layout point.

Can we just remove this and down the work inside LayoutRect?

[zalan]

Created attachment 237198 [details]
Patch

[WebKit Commit Bot]

Attachment 237198 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/LayoutPoint.h:184:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/graphics/LayoutPoint.h:210:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[zalan]

Created attachment 237246 [details]
Patch

[WebKit Commit Bot]

Attachment 237246 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/LayoutPoint.h:184:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/graphics/LayoutPoint.h:209:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[zalan]

Created attachment 237287 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 237287 [details]
Patch

Rejecting attachment 237287 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 237287, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Tools/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/4801182182670336

[zalan]

Created attachment 237288 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 237288 [details]
Patch

Clearing flags on attachment: 237288

Committed r173049: <http://trac.webkit.org/changeset/173049>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.