Summary: | TypeSet needs a mode where it no longer profiles structure shapes | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Saam Barati <saam> | ||||
Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | fpizlo, joepeck, timothy | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Saam Barati
2014-08-26 12:26:49 PDT
Created attachment 237882 [details]
patch
landed in: http://trac.webkit.org/changeset/173469 Comment on attachment 237882 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=237882&action=review > Source/JavaScriptCore/runtime/TypeProfiler.cpp:109 > + json.append(","); > + > + json.append("\"isOverflown\":"); StringBuilder has some better methods you can use: StringBuilder::append(char) - for single character appends StringBuilder::appendLiteral - for string literals with the length provided at compile time You could use both of these within this method. |