Bug 136245

Summary:

[EFL] Build break using clang

Product:

WebKit

Reporter:

Ryuan Choi <ryuan.choi>

Component:

WebKit EFL

Assignee:

Ryuan Choi <ryuan.choi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

lucas.de.marchi

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	gyuyoung.kim: review+

Description Ryuan Choi 2014-08-26 00:26:43 PDT

While building ewebkit via clang, there are some build issues.
1. Too many warnings in system libraries and WebKit code.
2. Build break of UnitTestUtils because of rtti in gtest header
3. undefined reference to `WebCore::Node::renderStyle() const in Source/WebCore/css/ViewportStyleResolver.cpp

Comment 1 Ryuan Choi 2014-08-26 00:29:35 PDT

Created attachment 237137 [details]
Patch

Comment 2 Gyuyoung Kim 2014-08-26 03:22:12 PDT

Comment on attachment 237137 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237137&action=review

Please fix my comment.

> Source/WebCore/css/ViewportStyleResolver.cpp:37
> +#include "NodeRenderStyle.h"

I believe this include won't harmful on other ports.

> Source/WebKit2/PlatformEfl.cmake:457
> +    -DGTEST_HAS_RTTI=0

GTK port also disabled this macro.

> Source/cmake/OptionsEfl.cmake:11
> +# Disable WERROR in clang build because of many warnings.

Add FIXME: prefix.

Comment 3 Ryuan Choi 2014-08-26 03:54:37 PDT

Committed r172954: <http://trac.webkit.org/changeset/172954>