Bug 136234

Summary: Don't crash when the DataDetectors framework is unavailable.
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: thorton
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Attachments:
Description Flags
Patch v1 thorton: review+

Description Brady Eidson 2014-08-25 15:00:05 PDT
Don't crash when the DataDetectors framework is unavailable.

It's possible to run the same build of WebKit2 that expected DD.framework to be available in an environment that does not have it available.

In that environment, it should just early-return by skipping a whole bunch of work that is irrelevant.

In Radar - rdar://problem/18106066
Comment 1 Brady Eidson 2014-08-25 15:05:06 PDT
Created attachment 237108 [details]
Patch v1
Comment 2 Tim Horton 2014-08-25 15:21:47 PDT
Comment on attachment 237108 [details]
Patch v1

Should you defend MenuUtilities.mm as well, or is it OK because we'll never get there with these early returns in place?
Comment 3 Brady Eidson 2014-08-25 15:25:21 PDT
(In reply to comment #2)
> (From update of attachment 237108 [details])
> Should you defend MenuUtilities.mm as well, or is it OK because we'll never get there with these early returns in place?

I couldn't find a way you'd end up in MenuUtilities with these in place.  I'll double check.
Comment 4 Brady Eidson 2014-08-25 15:31:25 PDT
http://trac.webkit.org/changeset/172939