Bug 136224

Summary: [EFL] Share fast/speechsynthesis/ with other ports
Product: WebKit Reporter: Krzysztof Czech <k.czech>
Component: WebKit EFLAssignee: Krzysztof Czech <k.czech>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cfleizach, commit-queue, gyuyoung.kim, lucas.de.marchi, rakuco, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Description Krzysztof Czech 2014-08-25 06:09:32 PDT 
webkit.org/b/136127 introduces platform support for WebSpeech in EFL.
I propose to share fast/speechsynthesis tests so that other ports (EFL) could use them.
Tests seem to be generic so they do not really need any modifications.

I will skip them in other ports, they do not support them yet.
Comment 1 Krzysztof Czech 2014-08-26 07:46:46 PDT 
Created attachment 237151 [details]
patch
Comment 2 chris fleizach 2014-08-26 10:08:13 PDT 
Comment on attachment 237151 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237151&action=review

> Source/cmake/OptionsEfl.cmake:109
> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SPEECH_SYNTHESIS ON)

it seems like we might want to wait until it's implemented before turning it on
or did the implementation already go in?
Comment 3 Krzysztof Czech 2014-08-26 14:13:44 PDT 
(In reply to comment #2)
> (From update of attachment 237151 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=237151&action=review
> 
> > Source/cmake/OptionsEfl.cmake:109
> > +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SPEECH_SYNTHESIS ON)
> 
> it seems like we might want to wait until it's implemented before turning it on
> or did the implementation already go in?
Yes, the implementation is already in (r172956)
Comment 4 WebKit Commit Bot 2014-08-27 01:04:28 PDT 
Comment on attachment 237151 [details]
patch

Clearing flags on attachment: 237151

Committed r173000: <http://trac.webkit.org/changeset/173000>
Comment 5 WebKit Commit Bot 2014-08-27 01:04:34 PDT 
All reviewed patches have been landed.  Closing bug.