Bug 136209

Summary: [GTK] Unify webkitgtk and webkit2gtk directories
Product: WebKit Reporter: Alberto Garcia <berto>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cgarcia, commit-queue, gyuyoung.kim, rakuco, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alberto Garcia
Reported 2014-08-25 00:24:51 PDT
We are using ${libexec}/webkitgtk-4.0/ to install the web, plugin and network process binaries, however we are using webkit2gtk everywhere else (including in the injected bundle installation path). I don't know if there's a good reason to keep them separate, so I propose that we use the same name for both. See also bug 135754.
Attachments
Patch (1.62 KB, patch)
2014-08-25 00:30 PDT, Alberto Garcia
no flags
Alberto Garcia
Comment 1 2014-08-25 00:30:45 PDT
Carlos Garcia Campos
Comment 2 2014-08-25 05:30:52 PDT
(In reply to comment #0) > We are using ${libexec}/webkitgtk-4.0/ to install the web, plugin and > network process binaries, however we are using webkit2gtk everywhere > else (including in the injected bundle installation path). Well, not everything else, we use webkitgtk-4.0 for the header files, because webkitgtk is the name of the package, and it contains subdirectories for the header files of the different public APIs. > I don't know if there's a good reason to keep them separate, so I > propose that we use the same name for both. > > See also bug 135754.
Carlos Garcia Campos
Comment 3 2014-08-25 05:31:38 PDT
Comment on attachment 237064 [details] Patch Ok.
WebKit Commit Bot
Comment 4 2014-08-25 06:05:49 PDT
Comment on attachment 237064 [details] Patch Clearing flags on attachment: 237064 Committed r172921: <http://trac.webkit.org/changeset/172921>
WebKit Commit Bot
Comment 5 2014-08-25 06:05:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.