Bug 136209

Summary: [GTK] Unify webkitgtk and webkit2gtk directories
Product: WebKit Reporter: Alberto Garcia <berto>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cgarcia, commit-queue, gyuyoung.kim, rakuco, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Alberto Garcia 2014-08-25 00:24:51 PDT
We are using ${libexec}/webkitgtk-4.0/ to install the web, plugin and
network process binaries, however we are using webkit2gtk everywhere
else (including in the injected bundle installation path).

I don't know if there's a good reason to keep them separate, so I
propose that we use the same name for both.

See also bug 135754.
Comment 1 Alberto Garcia 2014-08-25 00:30:45 PDT
Created attachment 237064 [details]
Patch
Comment 2 Carlos Garcia Campos 2014-08-25 05:30:52 PDT
(In reply to comment #0)
> We are using ${libexec}/webkitgtk-4.0/ to install the web, plugin and
> network process binaries, however we are using webkit2gtk everywhere
> else (including in the injected bundle installation path).

Well, not everything else, we use webkitgtk-4.0 for the header files, because webkitgtk is the name of the package, and it contains subdirectories for the header files of the different public APIs.

> I don't know if there's a good reason to keep them separate, so I
> propose that we use the same name for both.
> 
> See also bug 135754.
Comment 3 Carlos Garcia Campos 2014-08-25 05:31:38 PDT
Comment on attachment 237064 [details]
Patch

Ok.
Comment 4 WebKit Commit Bot 2014-08-25 06:05:49 PDT
Comment on attachment 237064 [details]
Patch

Clearing flags on attachment: 237064

Committed r172921: <http://trac.webkit.org/changeset/172921>
Comment 5 WebKit Commit Bot 2014-08-25 06:05:53 PDT
All reviewed patches have been landed.  Closing bug.