| Summary: | Reduce style marking when using the pseudo class :placeholder-shown | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||||
| Component: | New Bugs | Assignee: | Benjamin Poulain <benjamin> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | buildbot, rniwa | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Benjamin Poulain
2014-08-24 16:25:59 PDT
Created attachment 237049 [details]
Patch
Comment on attachment 237049 [details]
Patch
Is there anyway to share code between those four different functions that all do variations on the same thing?
(In reply to comment #2) > (From update of attachment 237049 [details]) > Is there anyway to share code between those four different functions that all do variations on the same thing? It's tricky, the compiler knows exactly what is going on with styling in order to optimize properly. I could easily templatize the marking section but IMHO that would only increase complexity. Any opinion? Comment on attachment 237049 [details] Patch Attachment 237049 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5383619476455424 New failing tests: compositing/checkerboard.html compositing/bounds-in-flipped-writing-mode.html accessibility/adjacent-continuations-cause-assertion-failure.html animations/animation-border-overflow.html animations/3d/transform-origin-vs-functions.html http/tests/appcache/abort-cache-onchecking.html animations/3d/state-at-end-event-transform.html animations/animation-add-events-in-handler.html animations/animation-controller-drt-api.html animations/additive-transform-animations.html canvas/philip/tests/2d.clearRect+fillRect.basic.html http/tests/appcache/abort-cache-onchecking-resource-404.html accessibility/alt-tag-on-image-with-nonimage-role.html canvas/philip/tests/2d.clearRect+fillRect.alpha0.html Created attachment 237063 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 237049 [details] Patch Clearing flags on attachment: 237049 Committed r172933: <http://trac.webkit.org/changeset/172933> All reviewed patches have been landed. Closing bug. |