Summary: | DOMTimer may be deleted during timer fire | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gavin Barraclough <barraclough> | ||||||
Component: | Bindings | Assignee: | Gavin Barraclough <barraclough> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ap, commit-queue, darin, esprehn+autocc, ggaren, kangil.han, ossy, thorton | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 136197 | ||||||||
Attachments: |
|
Description
Gavin Barraclough
2014-08-23 23:30:19 PDT
Created attachment 237115 [details]
Fix
Attachment 237115 [details] did not pass style-queue:
ERROR: Source/WebCore/page/DOMTimer.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 237115 [details]
Fix
r=me
Something I said in person: Perhaps ScriptExecutionContext::m_timeouts should just be a map of RefPtr instead of raw pointer. Created attachment 237154 [details]
Alternative fix, address the problem for DOMTimer too.
Comment on attachment 237154 [details]
Alternative fix, address the problem for DOMTimer too.
r=me
Transmitting file data ...... Committed revision 172963. Comment on attachment 237154 [details] Alternative fix, address the problem for DOMTimer too. View in context: https://bugs.webkit.org/attachment.cgi?id=237154&action=review > Source/WebCore/page/DOMTimer.h:31 > +#include <WTF/RefCounted.h> It broke the Linux (EFL,GTK) builds, because this kind of magic includes work only on Mac. It seems, it isn't Linux issue, Apple Mac build is broken too. I assume, you need wtf/RefCounted.h instead of WTF/RefCounted.h . Tim already fixed it in http://trac.webkit.org/changeset/172964, thanks. Comment on attachment 237154 [details] Alternative fix, address the problem for DOMTimer too. View in context: https://bugs.webkit.org/attachment.cgi?id=237154&action=review >> Source/WebCore/page/DOMTimer.h:31 >> +#include <WTF/RefCounted.h> > > It broke the Linux (EFL,GTK) builds, because this kind of magic includes work only on Mac. Slightly incorrect analysis. It’s not about “magic includes”, but simply case sensitive file systems. The correct include is <wtf/RefCounted.h>. Using <WTF/RefCounted.h> instead breaks builds on Macs with case sensitive file systems too. However, the HFS case insensitive file system is the one that many of us have on our computers. (In reply to comment #9) > It seems, it isn't Linux issue, Apple Mac build is broken too. > I assume, you need wtf/RefCounted.h instead of WTF/RefCounted.h . Oops, I see you figured this out. Sorry for the repetitive comment. |