Bug 136196

Summary: build.webkit.org/dashboard: Add a metrics page with overall bot performance results
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Enhancement CC: bshafiei, mjs, sam, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 136195    
Bug Blocks:    
Attachments:
Description Flags
choose date range
none
results
none
scrolled down to reveal platforms
none
proposed patch
none
proposed patch
none
proposed patch
none
proposed patch timothy: review+

Description Alexey Proskuryakov 2014-08-23 19:53:09 PDT
I'd like to display results such as:

- how often are bots red?
- how long does it take from landing a patch to getting results from bots?
Comment 1 Alexey Proskuryakov 2014-08-23 20:05:30 PDT
Created attachment 237035 [details]
choose date range
Comment 2 Alexey Proskuryakov 2014-08-23 20:05:53 PDT
Created attachment 237036 [details]
results
Comment 3 Alexey Proskuryakov 2014-08-23 20:06:20 PDT
Created attachment 237037 [details]
scrolled down to reveal platforms
Comment 4 Alexey Proskuryakov 2014-08-23 20:08:53 PDT
Created attachment 237038 [details]
proposed patch
Comment 5 Alexey Proskuryakov 2014-08-25 10:47:28 PDT
Created attachment 237093 [details]
proposed patch

With a small fix to avoid an assertion when date picker returns an invalid date.
Comment 6 Alexey Proskuryakov 2014-08-26 23:45:16 PDT
Created attachment 237210 [details]
proposed patch

Changes from previous version:
1. Applied the fix for bug 136282 (would be nice to share this code between regular dashboard and the metrics page).
2. Now that we have branch support enabled on Trac, ignore non-trunk commits for better accuracy.
Comment 7 Alexey Proskuryakov 2014-08-26 23:46:28 PDT
Created attachment 237211 [details]
proposed patch

Uploaded a wrong version.
Comment 8 Timothy Hatcher 2014-08-27 07:43:44 PDT
Comment on attachment 237211 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237211&action=review

Looks great!

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:51
> +        if (queue.builder) {
> +            categoryName = "builders";
> +        } else if (queue.tester) {
> +            categoryName = queue.testCategory;
> +        } else {

Can drop the braces.
Comment 9 Alexey Proskuryakov 2014-08-27 10:14:42 PDT
Committed <http://trac.webkit.org/r173008>.