| Summary: | build.webkit.org/dashboard: Add a metrics page with overall bot performance results | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||||||||||||
| Component: | Tools / Tests | Assignee: | Alexey Proskuryakov <ap> | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Enhancement | CC: | bshafiei, mjs, sam, timothy | ||||||||||||||||
| Priority: | P2 | ||||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||
| Bug Depends on: | 136195 | ||||||||||||||||||
| Bug Blocks: | |||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
Alexey Proskuryakov
2014-08-23 19:53:09 PDT
Created attachment 237035 [details]
choose date range
Created attachment 237036 [details]
results
Created attachment 237037 [details]
scrolled down to reveal platforms
Created attachment 237038 [details]
proposed patch
Created attachment 237093 [details]
proposed patch
With a small fix to avoid an assertion when date picker returns an invalid date.
Created attachment 237210 [details] proposed patch Changes from previous version: 1. Applied the fix for bug 136282 (would be nice to share this code between regular dashboard and the metrics page). 2. Now that we have branch support enabled on Trac, ignore non-trunk commits for better accuracy. Created attachment 237211 [details]
proposed patch
Uploaded a wrong version.
Comment on attachment 237211 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=237211&action=review Looks great! > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:51 > + if (queue.builder) { > + categoryName = "builders"; > + } else if (queue.tester) { > + categoryName = queue.testCategory; > + } else { Can drop the braces. Committed <http://trac.webkit.org/r173008>. |