| Summary: | build.webkit.org/dashboard unnecessarily loads results of hidden queues | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||
| Component: | Tools / Tests | Assignee: | Alexey Proskuryakov <ap> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, thorton, timothy | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 136196 | ||||||||
| Attachments: |
|
||||||||
|
Description
Alexey Proskuryakov
2014-08-23 19:22:42 PDT
Created attachment 237034 [details]
proposed fix
Comment on attachment 237034 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=237034&action=review > Tools/ChangeLog:13 > + are triggered by views, so it only makes sens to do the same for initial update. sens*e* for *the* initial update? > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:35 > + setTimeout(function() { this._updateHiddenState(); }.bind(this), 0); Should you do this more like the next line does? Is there a reason for the extra function? Created attachment 237043 [details]
patch for landing
Comment on attachment 237043 [details] patch for landing Clearing flags on attachment: 237043 Committed r172893: <http://trac.webkit.org/changeset/172893> All reviewed patches have been landed. Closing bug. |