Bug 136195

Summary: build.webkit.org/dashboard unnecessarily loads results of hidden queues
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, thorton, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 136196    
Attachments:
Description Flags
proposed fix
thorton: review+
patch for landing none

Alexey Proskuryakov
Reported 2014-08-23 19:22:42 PDT
There is code meant to prevent loading hidden queues, but it's broken.
Attachments
proposed fix (5.96 KB, patch)
2014-08-23 19:29 PDT, Alexey Proskuryakov 		thorton: review+
DetailsFormatted DiffDiff
patch for landing (6.02 KB, patch)
2014-08-23 23:33 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2014-08-23 19:29:08 PDT
Created attachment 237034 [details] proposed fix
Tim Horton
Comment 2 2014-08-23 22:44:06 PDT
Comment on attachment 237034 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=237034&action=review > Tools/ChangeLog:13 > + are triggered by views, so it only makes sens to do the same for initial update. sens*e* for *the* initial update? > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:35 > + setTimeout(function() { this._updateHiddenState(); }.bind(this), 0); Should you do this more like the next line does? Is there a reason for the extra function?
Alexey Proskuryakov
Comment 3 2014-08-23 23:33:34 PDT
Created attachment 237043 [details] patch for landing
WebKit Commit Bot
Comment 4 2014-08-24 00:10:55 PDT
Comment on attachment 237043 [details] patch for landing Clearing flags on attachment: 237043 Committed r172893: <http://trac.webkit.org/changeset/172893>
WebKit Commit Bot
Comment 5 2014-08-24 00:10:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.