Bug 136191

Summary:

Web Inspector: Do not copy large module source strings

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, commit-queue, graouts, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Description Joseph Pecoraro 2014-08-22 19:24:41 PDT

We should use a non-copying WTFString constructor for the large inspector module strings:

    InjectedScriptSource_js
    CommandLineAPIModuleSource_js

Note, other compiled strings were not copied:

    XMLViewer_js
    XMLViewer_css

Comment 1 Radar WebKit Bug Importer 2014-08-22 19:25:36 PDT

<rdar://problem/18109945>

Comment 2 Joseph Pecoraro 2014-08-22 19:25:48 PDT

Created attachment 237021 [details]
[PATCH] Proposed Fix

Comment 3 WebKit Commit Bot 2014-08-23 01:17:05 PDT

Comment on attachment 237021 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 237021

Committed r172888: <http://trac.webkit.org/changeset/172888>

Comment 4 WebKit Commit Bot 2014-08-23 01:17:08 PDT

All reviewed patches have been landed.  Closing bug.