Bug 136176

Summary: Rubber-banding in overflow:scroll regions does not work correctly with direction:rtl
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, esprehn+autocc, glenn, kondapallykalyan, sam, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Test case
none
Patch sam: review+

Description Beth Dakin 2014-08-22 15:51:38 PDT 
Rubber-banding in overflow:scroll regions does not work correctly with direction:rtl
Comment 1 Beth Dakin 2014-08-22 15:52:25 PDT 
Created attachment 237004 [details]
Test case

Test case that shows the bug.
Comment 2 Beth Dakin 2014-08-22 16:02:32 PDT 
Created attachment 237006 [details]
Patch
Comment 3 Simon Fraser (smfr) 2014-08-22 16:07:30 PDT 
Comment on attachment 237006 [details]
Patch

no tests?
Comment 4 Beth Dakin 2014-08-22 16:48:55 PDT 
(In reply to comment #3)
> (From update of attachment 237006 [details])
> no tests?

I'm not sure that I can write a test that will actually behave differently with this change, but I will give it a shot.
Comment 5 Beth Dakin 2014-08-25 17:11:03 PDT 
(In reply to comment #3)
> (From update of attachment 237006 [details])
> no tests?

I spent some time today trying to make a test for this, and I still have not figured out how to make a reliable test. The momentum events that Brent added are cool, but they don't seem to be 100% consistent for replicating rubber-banding.
Comment 6 Beth Dakin 2014-08-25 17:13:22 PDT 
http://trac.webkit.org/changeset/172945
Comment 7 Tim Horton 2014-08-25 17:28:41 PDT 
Comment on attachment 237006 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237006&action=review

> Source/WebCore/rendering/RenderLayer.cpp:2645
> +    return IntRect(IntPoint(scrollPosition().x(), scrollPosition().y()),

Why not just IntRect(scrollPosition(), ...)? No need for all this fun.
Comment 8 Beth Dakin 2014-08-25 20:31:48 PDT 
(In reply to comment #7)
> (From update of attachment 237006 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=237006&action=review
> 
> > Source/WebCore/rendering/RenderLayer.cpp:2645
> > +    return IntRect(IntPoint(scrollPosition().x(), scrollPosition().y()),
> 
> Why not just IntRect(scrollPosition(), ...)? No need for all this fun.

r=you to fix, Tim?
Comment 9 Tim Horton 2014-08-25 21:03:52 PDT 
Absolutely!
Comment 10 Beth Dakin 2014-08-26 11:30:14 PDT 
(In reply to comment #9)
> Absolutely!

r172965 :D