Bug 136151

Summary: [EFL] Unskip compositing test
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, commit-queue, esprehn+autocc, glenn, hw1008.kim, kondapallykalyan, lucas.de.marchi, ossy, ryuan.choi, sergio, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Gyuyoung Kim
Reported 2014-08-22 02:03:11 PDT
SSIA
Attachments
Patch (2.50 KB, patch)
2014-08-22 02:09 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (2.63 KB, patch)
2014-08-22 20:51 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2014-08-22 02:09:54 PDT
Created attachment 236976 [details] Patch
Gyuyoung Kim
Comment 2 2014-08-22 20:48:16 PDT
Comment on attachment 236976 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236976&action=review > Source/WebCore/rendering/RenderLayerBacking.cpp:-298 > -#if !PLATFORM(IOS) && !PLATFORM(EFL) After adjust setContentsOpaque() again, almost compositing tests can be passed. 469 tests ran as expected, 51 didn't: Ryuan, should we keep this macro ?
Gyuyoung Kim
Comment 3 2014-08-22 20:51:02 PDT
Created attachment 237024 [details] Patch
Gyuyoung Kim
Comment 4 2014-08-24 21:41:51 PDT
CC'ing Ossy.
Ryuan Choi
Comment 5 2014-08-24 21:46:00 PDT
(In reply to comment #3) > Created an attachment (id=237024) [details] > Patch OK. Looks fine to me. It was for the transparent webview (ewk_view_bg_color_set). Unfortunately, WebKitTestRunnder/Efl uses different composting path from general ewk_view. I agree that skipping composting/ is not for development. I will keep in mind of this intentional regression for the release until we fix the root cause.
Gyuyoung Kim
Comment 6 2014-08-26 19:55:52 PDT
Ossy, could you take a look ?
Csaba Osztrogonác
Comment 7 2014-08-27 00:19:30 PDT
Comment on attachment 237024 [details] Patch rs=me
WebKit Commit Bot
Comment 8 2014-08-27 00:56:22 PDT
Comment on attachment 237024 [details] Patch Clearing flags on attachment: 237024 Committed r172999: <http://trac.webkit.org/changeset/172999>
WebKit Commit Bot
Comment 9 2014-08-27 00:56:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.