| Summary: | [EFL] Unskip compositing test | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||||
| Component: | WebKit EFL | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bunhere, cdumez, commit-queue, esprehn+autocc, glenn, hw1008.kim, kondapallykalyan, lucas.de.marchi, ossy, ryuan.choi, sergio, simon.fraser | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Gyuyoung Kim
2014-08-22 02:03:11 PDT
Created attachment 236976 [details]
Patch
Comment on attachment 236976 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236976&action=review > Source/WebCore/rendering/RenderLayerBacking.cpp:-298 > -#if !PLATFORM(IOS) && !PLATFORM(EFL) After adjust setContentsOpaque() again, almost compositing tests can be passed. 469 tests ran as expected, 51 didn't: Ryuan, should we keep this macro ? Created attachment 237024 [details]
Patch
CC'ing Ossy. (In reply to comment #3) > Created an attachment (id=237024) [details] > Patch OK. Looks fine to me. It was for the transparent webview (ewk_view_bg_color_set). Unfortunately, WebKitTestRunnder/Efl uses different composting path from general ewk_view. I agree that skipping composting/ is not for development. I will keep in mind of this intentional regression for the release until we fix the root cause. Ossy, could you take a look ? Comment on attachment 237024 [details]
Patch
rs=me
Comment on attachment 237024 [details] Patch Clearing flags on attachment: 237024 Committed r172999: <http://trac.webkit.org/changeset/172999> All reviewed patches have been landed. Closing bug. |