Bug 136142

Summary: [Win] WebCore.proj is not copying WebKit resource files
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebCore Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Blocker CC: bfulgham, webkit-bug-importer
Priority: P1 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch
none
Patch thorton: review+

Description Brent Fulgham 2014-08-21 18:08:59 PDT
The WebCore project is where the English.lproj files are stored. These need to be included in the WebKit.resources file used by WebKit.dll. While the main WebKit.sln build properly copies these files, the stand-along MSBuild project "WebCore.proj" was not doing so.

This patch corrects this oversight.
Comment 1 Brent Fulgham 2014-08-21 18:09:24 PDT
<rdar://problem/17733682>
Comment 2 Brent Fulgham 2014-08-21 18:11:16 PDT
Created attachment 236950 [details]
Patch
Comment 3 Brent Fulgham 2014-08-21 18:13:37 PDT
Created attachment 236952 [details]
Patch
Comment 4 Tim Horton 2014-08-21 18:18:33 PDT
Comment on attachment 236952 [details]
Patch

rs=me
Comment 5 Brent Fulgham 2014-08-21 18:19:23 PDT
Committed r172841: <http://trac.webkit.org/changeset/172841>