Bug 13614

Summary:

[S60] 3.2 BrowserNG: Find Phonenumber doesn't make a call

Product:

WebKit

Reporter:

George Guo <george.guo>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

CLOSED FIXED

Severity:

Normal

CC:

george.guo

Priority:

Version:

523.x (Safari 3)

Hardware:

Other

OS:

S60 3rd edition

Attachments:

Description	Flags
solution patch	Sachin.Padma: review-
new patch with modifications based on previous review	Sachin.Padma: review-
New patch	Sachin.Padma: review+

George Guo

Reported 2007-05-07 12:48:23 PDT

Please specify the following information: QC test case - ]MSK - Auto find off - phone num - Use case: Preconditions: Browser is running. Options/Preferences/Page/Smart text recognition set to Off (§qtn_browsers_sett_smartlink§ in §qtn_browsers_title_page§ ) Load page http://testsuite.nokia-boston.com/content/S60NG_autofinditem/search_auto_manual.html - Steps to reproduce: 1.Select Options/ Find/Phone number (§qtn_options_find§ -> §qtn_options_find_phone_number§) 2.Options menu is closed. 3. Move the pointer to the first phone number on the page. Phone number in the page is identified with a call icon "phone" next to it. 3. Press Selection Key - Expected outcome: A call to the number in focus will be initiated when selectection key was selected - Actual outcome: No call was made when selection key was selected. Nothing happends. The same page was displayed. Lotus Notes ID: ISHG-6YFNME

Attachments
solution patch (3.38 KB, patch) 2007-05-07 13:14 PDT, George Guo	Sachin.Padma: review-	Details Formatted Diff Diff
new patch with modifications based on previous review (4.55 KB, patch) 2007-05-09 11:02 PDT, George Guo	Sachin.Padma: review-	Details Formatted Diff Diff
New patch (5.59 KB, patch) 2007-05-10 15:09 PDT, George Guo	Sachin.Padma: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

George Guo

Comment 1 2007-05-07 13:14:00 PDT

Created attachment 14400 [details] solution patch This is the solution for bug ISHG-6YFME

Sachin Padma

Comment 2 2007-05-08 08:01:52 PDT

Comment on attachment 14400 [details] solution patch Formatting is not correct. Also LC function is used inside a non LC function.

George Guo

Comment 3 2007-05-09 11:02:12 PDT

Created attachment 14435 [details] new patch with modifications based on previous review New patch with modifications based on previous review were added

Sachin Padma

Comment 4 2007-05-10 12:53:48 PDT

Comment on attachment 14435 [details] new patch with modifications based on previous review does not need to be member variable

George Guo

Comment 5 2007-05-10 15:09:08 PDT

Created attachment 14477 [details] New patch The member object was taken away, and Leave function were taken care of

Sachin Padma

Comment 6 2007-05-10 15:23:08 PDT

Comment on attachment 14477 [details] New patch r=me

Sachin Padma

Comment 7 2007-05-10 15:24:35 PDT

landed in ccb in r21382

Note You need to log in before you can comment on or make changes to this bug.