Bug 136137

Summary: Add support for Bopomofo Ruby (ruby-position: inter-character)
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jonlee, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch sam: review+

Dave Hyatt
Reported 2014-08-21 16:31:14 PDT
Bug to track adding support for Bopomofo Ruby capability (ruby-position: inter-character).
Attachments
Patch (90.33 KB, patch)
2014-08-21 16:43 PDT, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Patch (90.25 KB, patch)
2014-08-21 18:20 PDT, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Patch (90.84 KB, patch)
2014-08-22 10:03 PDT, Dave Hyatt 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2014-08-21 16:43:06 PDT
Created attachment 236946 [details] Patch
WebKit Commit Bot
Comment 2 2014-08-21 16:45:47 PDT
Attachment 236946 [details] did not pass style-queue: ERROR: Source/WebCore/css/DeprecatedStyleBuilder.cpp:832: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/DeprecatedStyleBuilder.cpp:833: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/DeprecatedStyleBuilder.cpp:834: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 3 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dave Hyatt
Comment 3 2014-08-21 18:20:04 PDT
Created attachment 236953 [details] Patch
Dave Hyatt
Comment 4 2014-08-22 10:03:11 PDT
Created attachment 236988 [details] Patch
WebKit Commit Bot
Comment 5 2014-08-22 10:04:16 PDT
Attachment 236988 [details] did not pass style-queue: ERROR: Source/WebCore/css/DeprecatedStyleBuilder.cpp:42: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dave Hyatt
Comment 6 2014-08-22 11:19:18 PDT
Landed in r172861.
Jon Lee
Comment 7 2014-08-22 15:14:26 PDT
<rdar://problem/12567545>
Note You need to log in before you can comment on or make changes to this bug.