Bug 136137

Summary: Add support for Bopomofo Ruby (ruby-position: inter-character)
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jonlee, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch sam: review+

Description Dave Hyatt 2014-08-21 16:31:14 PDT
Bug to track adding support for Bopomofo Ruby capability (ruby-position: inter-character).
Comment 1 Dave Hyatt 2014-08-21 16:43:06 PDT
Created attachment 236946 [details]
Patch
Comment 2 WebKit Commit Bot 2014-08-21 16:45:47 PDT
Attachment 236946 [details] did not pass style-queue:


ERROR: Source/WebCore/css/DeprecatedStyleBuilder.cpp:832:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/css/DeprecatedStyleBuilder.cpp:833:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/css/DeprecatedStyleBuilder.cpp:834:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 3 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dave Hyatt 2014-08-21 18:20:04 PDT
Created attachment 236953 [details]
Patch
Comment 4 Dave Hyatt 2014-08-22 10:03:11 PDT
Created attachment 236988 [details]
Patch
Comment 5 WebKit Commit Bot 2014-08-22 10:04:16 PDT
Attachment 236988 [details] did not pass style-queue:


ERROR: Source/WebCore/css/DeprecatedStyleBuilder.cpp:42:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Dave Hyatt 2014-08-22 11:19:18 PDT
Landed in r172861.
Comment 7 Jon Lee 2014-08-22 15:14:26 PDT
<rdar://problem/12567545>