| Summary: | Add a button to enable paint flashing in the web inspector | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | Web Inspector | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | graouts, joepeck, simon.fraser, timothy, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2014-08-21 15:27:37 PDT
Created attachment 236939 [details]
Patch
Comment on attachment 236939 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236939&action=review > Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:36 > + paintFlashingImage = {src: "Images/PaintFlashing.svg", width: 16, height: 16}; This isn't needed since the two image paths are the same. > Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:40 > + paintFlashingImage = {src: "Images/PaintFlashing.svg", width: 13, height: 13}; Ditto. > Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:47 > + this._paintFlashingButtonNavigationItem = new WebInspector.ActivateButtonNavigationItem("paint-flashing", WebInspector.UIString("Enable paint flashing"), WebInspector.UIString("Disable paint flashing"), paintFlashingImage.src, paintFlashingImage.width, paintFlashingImage.height); You can use put the image path and size directly here. The width and height should always be 16 to match the SVG. |