Bug 136133 – Add a button to enable paint flashing in the web inspector

• Component: Web Inspector
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

Add a button to enable paint flashing in the web inspector

[Simon Fraser (smfr)]

Created attachment 236939 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/18094974>

[Timothy Hatcher]

Comment on attachment 236939 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236939&action=review

> Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:36
> +        paintFlashingImage = {src: "Images/PaintFlashing.svg", width: 16, height: 16};

This isn't needed since the two image paths are the same.

> Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:40
> +        paintFlashingImage = {src: "Images/PaintFlashing.svg", width: 13, height: 13};

Ditto.

> Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:47
> +    this._paintFlashingButtonNavigationItem = new WebInspector.ActivateButtonNavigationItem("paint-flashing", WebInspector.UIString("Enable paint flashing"), WebInspector.UIString("Disable paint flashing"), paintFlashingImage.src, paintFlashingImage.width, paintFlashingImage.height);

You can use put the image path and size directly here. The width and height should always be 16 to match the SVG.

[Simon Fraser (smfr)]

https://trac.webkit.org/r172839