Summary: | [GTK] Remove a focus ring on anchor node when focused by mouse. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | ChangSeok Oh <changseok> | ||||||
Component: | WebKitGTK | Assignee: | ChangSeok Oh <changseok> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cgarcia, changseok, commit-queue, esprehn+autocc, gustavo, gyuyoung.kim, hs85.jeong, jdiggs, jh718.park, mario, mrobinson | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
ChangSeok Oh
2014-08-20 22:34:18 PDT
Created attachment 236916 [details]
Patch
Does caret browsing still work after this change? (In reply to comment #2) > Does caret browsing still work after this change? Yes, it does. The patch only affects the mouse event related focus ring. Any concern? (In reply to comment #4) > Any concern? I'm not sure, I personally find it useful, sometimes when I'm opening links in a new tabs and then go back to the previous page, I quickly find the last opened link because it's focused. Maybe we should ask the GNOME designers what their take on this is? (In reply to comment #5) > (In reply to comment #4) > > Any concern? > > I'm not sure, I personally find it useful, sometimes when I'm opening links in a new tabs and then go back to the previous page, I quickly find the last opened link because it's focused. Aha, I got your point and partially agree on your thought. For a text link, :visited selector is helpful in that case, but it's not for an image link.. BTW do we really need to remember the last position what I clicked even when using a mouse? Hrm.. I don't know. Some people could feel the dotted line is useful, but some others feels it just looks ugly. Personally I lean to the latter and think it would be ok that following the behavior of other browsers. However I don't want to push my thought, yeah. as Gustavo said, it would be good to hear GNOME designers' opinion. Who is the best person? :) Comment on attachment 236916 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236916&action=review I vote for following what other browsers do. Especially for following what the Mac port does. Questions like these are not the expertise of GNOME designers. Please, wait a few days or for a comment from Carlos before committing, in case he wants to object. > Source/WebCore/html/HTMLAnchorElement.cpp:99 > +#if !PLATFORM(EFL) I suspect EFL is only doing this because it's what we did. I'd say you should just remove this whole #if, and also remove the EFL test expectation. I doubt EFL wants to be the only port with different behavior here. Comment on attachment 236916 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236916&action=review >> Source/WebCore/html/HTMLAnchorElement.cpp:99 >> +#if !PLATFORM(EFL) > > I suspect EFL is only doing this because it's what we did. I'd say you should just remove this whole #if, and also remove the EFL test expectation. I doubt EFL wants to be the only port with different behavior here. Hunseop and Joongheon, do you need to keep this feature for Tizen ? (In reply to comment #9) > Comment on attachment 236916 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=236916&action=review > > >> Source/WebCore/html/HTMLAnchorElement.cpp:99 > >> +#if !PLATFORM(EFL) > > > > I suspect EFL is only doing this because it's what we did. I'd say you should just remove this whole #if, and also remove the EFL test expectation. I doubt EFL wants to be the only port with different behavior here. > > Hunseop and Joongheon, do you need to keep this feature for Tizen ? We don't think it is necessary to keep this behaviour in Tizen. And IMHO, it would be better to have consistency with other ports, and looks more neat without the focus ring. I prefer to keep it, but if you all think it's better to remove it, I won't oppose. (In reply to comment #11) > I prefer to keep it, but if you all think it's better to remove it, I won't > oppose. Good to hear that! Let me rebase the patch. Thanks everyone for bringing this up again. ;) Created attachment 269436 [details]
Patch
Comment on attachment 269436 [details]
Patch
r=me
Comment on attachment 269436 [details] Patch Clearing flags on attachment: 269436 Committed r195447: <http://trac.webkit.org/changeset/195447> Patch landed. Close. |