Bug 13612

Summary:

Provide additional comments for the font and glyph systems

Product:

WebKit

Reporter:

Brett Wilson (Google) <brettw>

Component:

WebCore Misc.

Assignee:

Brett Wilson (Google) <brettw>

Status:

RESOLVED FIXED

Severity:

Minor

Priority:

Version:

523.x (Safari 3)

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
Add comments for glyph files.	none

Brett Wilson (Google)

Reported 2007-05-07 09:59:29 PDT

I spent some time trying to figure out the font fallback, caching, and glyph systems. It is complex and not well-documented. We should provide some better comments explaining what is going on.

Attachments
Add comments for glyph files. (10.10 KB, patch) 2007-05-07 17:09 PDT, Brett Wilson (Google)	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Brett Wilson (Google)

Comment 1 2007-05-07 17:09:08 PDT

Created attachment 14405 [details] Add comments for glyph files. This adds more comments to the glyph system. I also added one assertion.

Dave Hyatt

Comment 2 2007-05-07 17:19:30 PDT

I'll handle this.

Dave Hyatt

Comment 3 2007-05-07 17:21:17 PDT

Comment on attachment 14405 [details] Add comments for glyph files. The comments conflict with the changes in bug 3315 (which moves the roots among other things).

Dave Hyatt

Comment 4 2007-05-07 17:33:13 PDT

Comment on attachment 14405 [details] Add comments for glyph files. Clearing the review bit. I'm going to tweak these comments a bit in order to keep them consistent with 3315.

Brett Wilson (Google)

Comment 5 2007-05-07 18:08:37 PDT

Thanks Dave!

Dave Hyatt

Comment 6 2007-05-07 18:20:00 PDT

Ok, landed. Thanks for taking the time to write these comments. They helped me spot a bug in my changes in 3315. :)

Dave Hyatt

Comment 7 2007-05-07 18:26:00 PDT

Going to have to make GlyphPages refcounted.

Note You need to log in before you can comment on or make changes to this bug.