Bug 136113

Summary: REGRESSION(r172798): Broke builds (Requested by msaboff on #webkit).
Product: WebKit Reporter: WebKit Commit Bot <commit-queue>
Component: New BugsAssignee: WebKit Commit Bot <commit-queue>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, koivisto
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 136108    
Attachments:
Description Flags
ROLLOUT of r172798 none

Description WebKit Commit Bot 2014-08-20 11:31:53 PDT 
http://trac.webkit.org/changeset/172798 broke the build:
Broke builds (Requested by msaboff on #webkit).

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 WebKit Commit Bot 2014-08-20 11:32:11 PDT 
Created attachment 236885 [details]
ROLLOUT of r172798

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 WebKit Commit Bot 2014-08-20 11:33:59 PDT 
Attachment 236885 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/ios/wak/WKView.h:100:  The parameter name "rect" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/ios/wak/WKView.h:100:  The parameter name "context" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/ios/wak/WKView.h:100:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/ios/wak/WKView.h:106:  The parameter name "view" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/ios/wak/WKView.h:106:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/ios/wak/WKView.h:108:  The parameter name "view" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/ios/wak/WKView.h:108:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/ios/wak/WKView.h:109:  The parameter name "view" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/ios/wak/WKView.h:109:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/ios/wak/WKView.h:113:  The parameter name "view" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/ios/wak/WKView.h:113:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/ios/wak/WKView.h:115:  The parameter name "view" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/ios/wak/WKView.h:115:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/ios/wak/WKView.h:116:  The parameter name "view" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/ios/wak/WKView.h:116:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/ios/wak/WKView.h:119:  The parameter name "view" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/ios/wak/WKView.h:119:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/ios/wak/WKView.h:125:  The parameter name "view" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/ios/wak/WKView.h:125:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/ios/wak/WKView.h:126:  The parameter name "view" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/ios/wak/WKView.h:126:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/ios/wak/WKView.h:135:  The parameter name "view" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/ios/wak/WKView.h:135:  The parameter name "r" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/ios/wak/WKView.h:135:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/ios/wak/WKView.h:136:  The parameter name "view" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/ios/wak/WKView.h:136:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/ios/wak/WKView.h:142:  The parameter name "view" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/ios/wak/WKView.h:142:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/ios/wak/WKView.h:144:  The parameter name "view" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/ios/wak/WKView.h:144:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/ios/wak/WKView.h:145:  The parameter name "view" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/ios/wak/WKView.h:145:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/ios/wak/WKView.h:146:  The parameter name "view" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/ios/wak/WKView.h:146:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/graphics/Color.h:117:  The parameter name "a" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/Color.h:118:  The parameter name "b" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/transforms/AffineTransform.h:54:  The parameter name "b" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/transforms/AffineTransform.h:54:  The parameter name "d" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/transforms/AffineTransform.h:54:  The parameter name "e" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheStorage.h:59:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheStorage.h:65:  The parameter name "quota" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/ios/wak/WebCoreThreadMessage.h:53:  The parameter name "obj" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/ios/wak/WebCoreThreadMessage.h:56:  The parameter name "invocation" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/ios/wak/WebCoreThreadMessage.h:60:  The parameter name "invocation" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/ios/wak/WebCoreThreadMessage.h:63:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/sql/SQLiteDatabase.h:142:  Missing space inside { }.  [whitespace/braces] [5]
ERROR: Source/WebCore/loader/cache/CachedResource.h:223:  The parameter name "h" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/editing/Editor.h:333:  The parameter name "element" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/dom/Document.h:571:  Use 0 or null instead of NULL (even in *comments*).  [readability/null] [4]
ERROR: Source/WebCore/dom/Document.h:573:  Use 0 or null instead of NULL (even in *comments*).  [readability/null] [4]
ERROR: Source/WebCore/dom/Document.h:574:  Use 0 or null instead of NULL (even in *comments*).  [readability/null] [4]
ERROR: Source/WebCore/platform/network/AuthenticationChallengeBase.h:51:  The parameter name "a" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 52 in 104 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2014-08-20 11:38:00 PDT 
Comment on attachment 236885 [details]
ROLLOUT of r172798

Clearing flags on attachment: 236885

Committed r172802: <http://trac.webkit.org/changeset/172802>
Comment 4 WebKit Commit Bot 2014-08-20 11:38:03 PDT 
All reviewed patches have been landed.  Closing bug.