| Summary: | [GTK] Add the Wayland protocol extension | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||
| Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bunhere, commit-queue, gyuyoung.kim, mrobinson, rakuco, sergio | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 115803 | ||||||||
| Attachments: |
|
||||||||
|
Description
Zan Dobersek
2014-08-20 07:28:30 PDT
Created attachment 236870 [details]
Patch
Comment on attachment 236870 [details]
Patch
I think wl-wkgtk.xml should probably have a name that reflects what we typically do with C++ source files, descriptive and using non-abbreviated words when possible. Why not WebKitGtkWaylandClientProtocol.xml producing WebKitGtkWaylandClientProtocol.c (notice the flipped words from the existing name).
Yeah, that works better. Created attachment 236872 [details]
Patch
Comment on attachment 236872 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236872&action=review Thanks! Please do one more rename before landing. > Source/WebCore/platform/graphics/wayland/WebKitGtkWaylandClientProtocol.xml:2 > +<protocol name="wl_wkgtk"> Probably should rename this to wl_webkitgtk as well. > Source/WebCore/platform/graphics/wayland/WebKitGtkWaylandClientProtocol.xml:29 > + <interface name="wl_wkgtk" version="1"> Ditto. Committed r172856: <http://trac.webkit.org/changeset/172856> |