Bug 136102

Summary: [GTK] Add the Wayland protocol extension
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, commit-queue, gyuyoung.kim, mrobinson, rakuco, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 115803    
Attachments:
Description Flags
Patch
none
Patch mrobinson: review+, mrobinson: commit-queue-

Zan Dobersek
Reported 2014-08-20 07:28:30 PDT
[GTK] Add the Wayland protocol extension
Attachments
Patch (4.10 KB, patch)
2014-08-20 07:46 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (4.25 KB, patch)
2014-08-20 09:06 PDT, Zan Dobersek 		mrobinson: review+
mrobinson: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2014-08-20 07:46:36 PDT
Created attachment 236870 [details] Patch
Martin Robinson
Comment 2 2014-08-20 08:45:06 PDT
Comment on attachment 236870 [details] Patch I think wl-wkgtk.xml should probably have a name that reflects what we typically do with C++ source files, descriptive and using non-abbreviated words when possible. Why not WebKitGtkWaylandClientProtocol.xml producing WebKitGtkWaylandClientProtocol.c (notice the flipped words from the existing name).
Zan Dobersek
Comment 3 2014-08-20 08:56:19 PDT
Yeah, that works better.
Zan Dobersek
Comment 4 2014-08-20 09:06:24 PDT
Created attachment 236872 [details] Patch
Martin Robinson
Comment 5 2014-08-20 09:15:50 PDT
Comment on attachment 236872 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236872&action=review Thanks! Please do one more rename before landing. > Source/WebCore/platform/graphics/wayland/WebKitGtkWaylandClientProtocol.xml:2 > +<protocol name="wl_wkgtk"> Probably should rename this to wl_webkitgtk as well. > Source/WebCore/platform/graphics/wayland/WebKitGtkWaylandClientProtocol.xml:29 > + <interface name="wl_wkgtk" version="1"> Ditto.
Zan Dobersek
Comment 6 2014-08-22 01:20:38 PDT
Committed r172856: <http://trac.webkit.org/changeset/172856>
Note You need to log in before you can comment on or make changes to this bug.