Bug 136065

Summary: [GTK] [CSS Shapes] 23 failures on the tests imported from the W3C CSS Shapes test suite
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: bjonesbe, bugs-noreply, calvaris, cgarcia, cturner, fpizlo, jfernandez, mcatanzaro, rego, rhauck
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Crash log from shape-outside-circle-004.html none

Carlos Alberto Lopez Perez
Reported 2014-08-19 03:45:24 PDT
Revision r172733 <http://trac.webkit.org/r172733> imported 276 tests from the W3C CSS Shapes test suite. There were various failures common to all WebKit ports that were reported on bug 135923, bug 135925, bug 135926, and bug 135927. The following failures are specific to the GTK port: Regressions: Unexpected text-only failures (8) css3/shapes/shape-outside/values/shape-margin-001.html [ Failure ] css3/shapes/shape-outside/values/shape-outside-circle-004.html [ Failure ] css3/shapes/shape-outside/values/shape-outside-circle-005.html [ Failure ] css3/shapes/shape-outside/values/shape-outside-ellipse-004.html [ Failure ] css3/shapes/shape-outside/values/shape-outside-ellipse-005.html [ Failure ] css3/shapes/shape-outside/values/shape-outside-inset-003.html [ Failure ] css3/shapes/shape-outside/values/shape-outside-polygon-004.html [ Failure ] css3/shapes/shape-outside/values/shape-outside-shape-arguments-000.html [ Failure ] Regressions: Unexpected image-only failures (15) css3/shapes/shape-outside/shape-box/shape-outside-box-002.html [ ImageOnlyFailure ] css3/shapes/shape-outside/shape-box/shape-outside-box-003.html [ ImageOnlyFailure ] css3/shapes/shape-outside/shape-box/shape-outside-box-004.html [ ImageOnlyFailure ] css3/shapes/shape-outside/shape-box/shape-outside-box-006.html [ ImageOnlyFailure ] css3/shapes/shape-outside/shape-box/shape-outside-box-007.html [ ImageOnlyFailure ] css3/shapes/shape-outside/shape-box/shape-outside-box-008.html [ ImageOnlyFailure ] css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-017.html [ ImageOnlyFailure ] css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-027.html [ ImageOnlyFailure ] css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-017.html [ ImageOnlyFailure ] css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-010.html [ ImageOnlyFailure ] css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-011.html [ ImageOnlyFailure ] css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-012.html [ ImageOnlyFailure ] css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-013.html [ ImageOnlyFailure ] css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-014.html [ ImageOnlyFailure ] css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-015.html [ ImageOnlyFailure ] You can check the diffs here: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r172733%20%282204%29/css3/shapes/shape-outside/
Attachments
Crash log from shape-outside-circle-004.html (32.77 KB, text/plain)
2017-08-08 13:27 PDT, Charlie Turner 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1 2014-08-19 07:31:34 PDT
Updated the GTK TestExpectations for this failures on http://trac.webkit.org/changeset/172750
Carlos Garcia Campos
Comment 2 2017-02-10 02:51:24 PST
It seems some of these tests are duplicated in imported/w3c/csswg-test/css-shapes-1/shape-outside. imported/w3c/csswg-test/css-shapes-1/shape-outside/values/shape-margin-001.html [ Failure ] imported/w3c/csswg-test/css-shapes-1/shape-outside/values/shape-outside-circle-004.html [ Failure ] imported/w3c/csswg-test/css-shapes-1/shape-outside/values/shape-outside-circle-005.html [ Failure ] imported/w3c/csswg-test/css-shapes-1/shape-outside/values/shape-outside-ellipse-004.html [ Failure ] imported/w3c/csswg-test/css-shapes-1/shape-outside/values/shape-outside-ellipse-005.html [ Failure ] imported/w3c/csswg-test/css-shapes-1/shape-outside/values/shape-outside-inset-003.html [ Failure ] imported/w3c/csswg-test/css-shapes-1/shape-outside/values/shape-outside-polygon-004.html [ Failure ] imported/w3c/csswg-test/css-shapes-1/shape-outside/values/shape-outside-shape-arguments-000.html [ Failure ] imported/w3c/csswg-test/css-shapes-1/shape-outside/supported-shapes/circle/shape-outside-circle-027.html [ ImageOnlyFailure ] All these are also failing in blink, see crbug.com/441840 and crbug.com/443615
Charlie Turner
Comment 3 2017-08-08 13:27:16 PDT
Created attachment 317604 [details] Crash log from shape-outside-circle-004.html Starting seeing stack corruption in these tests after r220352, css3/shapes/shape-outside/values/shape-outside-circle-004.html [ Crash ] css3/shapes/shape-outside/values/shape-outside-ellipse-004.html [ Crash ] The crash log isn't terribly useful, because the stack is corrupted. Last signs of life are around JSDOMWindowBase::printErrorMessage.
Charlie Turner
Comment 4 2017-08-08 13:28:57 PDT
CC'd fpizlo on this one just in case there have been any other sightings of stack corruption with r220352
Charlie Turner
Comment 5 2017-08-08 13:31:24 PDT
The stack corruption is also non-deterministic, for a little extra spice.
Charlie Turner
Comment 6 2017-08-08 13:50:41 PDT
This was fixed right after I noticed it in https://trac.webkit.org/changeset/220416/webkit, very nice :)
Michael Catanzaro
Comment 7 2018-06-17 12:27:35 PDT
imported/w3c/web-platform-tests/css/css-shapes/shape-outside/supported-shapes/circle/shape-outside-circle-027.html was fixed by r232903. css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-027.html is still broken. Looks like that's the last affected test here.
Note You need to log in before you can comment on or make changes to this bug.