Summary: | EventSender dispatches should be per-Document | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brian Burg <burg> | ||||||||||
Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED LATER | ||||||||||||
Severity: | Normal | CC: | bburg, commit-queue, darin, dbates, esprehn+autocc, gyuyoung.kim, japhet, joepeck, kangil.han, kling, rakuco, ryuan.choi, sergio | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | 137397 | ||||||||||||
Bug Blocks: | 137090 | ||||||||||||
Attachments: |
|
Description
Brian Burg
2014-08-18 16:07:57 PDT
Created attachment 236793 [details]
Proposed Fix
I uploaded a patch to fix this. Looking forward to any feedback. I should probably write a replay test for this bug before landing, but the non-replay portions should be covered.
Splitting replay parts from the refactoring. Created attachment 238735 [details]
WIP
Created attachment 238741 [details]
Patch
Comment on attachment 238741 [details]
Patch
To remove a source of nondeterminism for web replay, this patch makes EventSenders associated with the Document, without trying to overly optimize or re-architect how EventSender works. I am not equipped to make useful (ie., data driven) performance optimizations on this code.
Created attachment 239062 [details]
Proposed Fix (+win build fix)
Comment on attachment 239062 [details]
Proposed Fix (+win build fix)
r=me, thanks for taking care of this.
Comment on attachment 239062 [details] Proposed Fix (+win build fix) Rejecting attachment 239062 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 239062, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/5927535393112064 Comment on attachment 239062 [details] Proposed Fix (+win build fix) View in context: https://bugs.webkit.org/attachment.cgi?id=239062&action=review > Source/WebCore/ChangeLog:5 > + You dropped the Reviewed By NOBODY line, which is why the commit queue complained about not being able to update that line. Comment on attachment 239062 [details] Proposed Fix (+win build fix) View in context: https://bugs.webkit.org/attachment.cgi?id=239062&action=review >> Source/WebCore/ChangeLog:5 >> + > > You dropped the Reviewed By NOBODY line, which is why the commit queue complained about not being able to update that line. Weird, didn't think I touched that! Will fix and land by `webkit-patch land` later tonight. Committed r174270: <http://trac.webkit.org/changeset/174270> But, needs to be rolled out as there are several crashes on bots. Closing web replay-related bugs until we resume working on the feature again. Mass move bugs into the DOM component. |