Web Inspector: check and cast InspectorObjects before passing to InspectorAgents

• Component: Web Inspector
• Status: NEW ---

[Brian Burg]

All in parameters for commands use raw InspectorObjects and do ad-hoc shape checking.

I think we can just generate assertValueHasExpectedType for all types and add accessors to the checked InspectorObject wrappers. Inside the dispatcher functions, all the argument shapes are asserted and casted in debug builds.

-- Original code from InspectorDebuggerAgent::setBreakpoint --

    RefPtr<InspectorObject> options = ...;
    String condition = emptyString();
    bool autoContinue = false;
    RefPtr<InspectorArray> actions;
    if (options) {
        (*options)->getString(ASCIILiteral("condition"), &condition);
        (*options)->getBoolean(ASCIILiteral("autoContinue"), &autoContinue);
        actions = (*options)->getArray(ASCIILiteral("actions"));
    }

-- Proposed refactor --

    RefPtr<Protocol::Debugger::Options> options = ...;
    String condition = emptyString();
    bool autoContinue = false;
    RefPtr<Protocol::Array<Protocol::Debugger::BreakpointAction>> actions;
    if (options) {
        options->getCondition(condition);
        options->getAutoContinue(autoContinue);
        options->getActions(actions);
    }


This would require the getters to take the argument by reference if the parameter is optional.

[Brian Burg]

Created attachment 241438 [details]
WIP

[Radar WebKit Bug Importer]

<rdar://problem/18960076>

[Radar WebKit Bug Importer]

<rdar://problem/18960075>